-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update usage of useInnerBlocksProps API #21625
Update usage of useInnerBlocksProps API #21625
Conversation
Formerly `__experimentalUseInnerBlocksProps`, the API has now become `useInnerBlocksProps` so we update usage.
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
I've never ran into this check failing before. It looks like the failure is caused by this line returning
It's true 8ed26f2 (a recent commit on |
I think this check, In summary, I think this can be safely ignored, as with the other failing checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly for me to fix the error on both platforms 🎉
This fixes an error caused by
__experimentalUseInnerBlocksProps
now becominguseInnerBlocksProps
, which occurred in WordPress/gutenberg#26031 (specifically this line).Changes proposed in this Pull Request:
__experimentalUseInnerBlocksProps
touseInnerBlocksProps
Jetpack product discussion
p9ugOq-1Tb-p2
Does this pull request change what data or activity we track or use?
Not, it does not.
Testing instructions:
See wordpress-mobile/gutenberg-mobile#4196