Adding hook for custom post status with tests #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryJones
requested changes
Nov 29, 2023
msm-sitemap.php
Outdated
| * | ||
| * @return string | ||
| */ | ||
| public static function get_post_status() { |
There was a problem hiding this comment.
Suggested change
| public static function get_post_status() { | |
| public static function get_post_status(): string { |
I'd suggest adding a type declaration on this, so that any effort to return a non-string is caught earlier before trying to pass it to the SQL query.
There was a problem hiding this comment.
Does this method need to be public?
There was a problem hiding this comment.
while it's not required, it does make it much easier to test such as the get_post_stati values mechanism.
There was a problem hiding this comment.
Don't mould the API for a class just to make testing either. Non-public methods can be tested via Reflection if necessary.
Co-authored-by: Gary Jones <[email protected]>
Co-authored-by: Gary Jones <[email protected]>
Co-authored-by: Gary Jones <[email protected]>
Co-authored-by: Gary Jones <[email protected]>
Co-authored-by: Gary Jones <[email protected]>
GaryJones
approved these changes
Dec 1, 2023
elysium001
deleted the
add/proposal-hook-generate-xml-for-nonpublish-post-status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Add
msm_sitemap_post_statusWordPress HookDescription: This pull request introduces a new WordPress hook,
msm_sitemap_post_status, to facilitate customization of post statuses for inclusion in the sitemap. This feature was specifically requested by a customer to enhance the flexibility of handling custom post statuses in the sitemap functionality.Changes Introduced:
msm_sitemap_post_statushook inmsm-sitemap.php.Background: A customer expressed the need for a way to use a post status other than 'published' to build the sitemap, prompting the development of this feature. The introduction of the
msm_sitemap_post_statushook allows developers to extend the sitemap functionality easily and integrate their custom post statuses.Related Issues:
Reviewers: TBD