feat(content-distribution): post status on create #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/content-distribution-status-on-create
…t/content-distribution-status-on-create
Base automatically changed from
fix/content-distribution-editor-outgoing-post
to
trunk
January 20, 2025 15:49
naxoc
approved these changes
Jan 20, 2025
| @@ -28,19 +28,16 @@ | |||
| } | |||
|
|
|||
| .editor-sidebar:not(#newspack-network-incoming-post\:newspack-network-content-distribution-panel, #edit-post\:document) { | |||
| @include grey-out-outer; | |||
|
|
|||
| @@ -0,0 +1,16 @@ | |||
| /** | |||
There was a problem hiding this comment.
Very minor: but why is it drafts plural? Should it not be singular?
There was a problem hiding this comment.
I didn't want to diverge from the source: https://github.com/WordPress/gutenberg/blob/2943dd3adfa4e1ad33b980760277377df9ac0f91/packages/editor/src/components/post-status/index.js
|
Hey @miguelpeixe, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1208510338230630-as-1209168371395424
p1737121608239039-slack-C055SRT7WN4
Support configuring the post status on distribution. This should only take effect when creating the post.
Testing