Stageplay: add theme #7930
Stageplay: add theme #7930
Conversation
Preview changesI've detected changes to the following themes in this PR: Vows, Professional Business, Hola, Maywood, Alves, Loïc, Photos, Elegant Business, Shawburn, Rockfield, Coutoire, Brompton, Inversum, Stow, Muscat, Stratford, Maverick, Exford, Morden, Seedlet, MyMenu, Mayland, Modern Business, Rivington, Sophisticated Business, Redhill, Balasana, Calm Business, Hever, Assembler, Foam, Barnsbury, LeanCV, Stageplay, Dalston, George Lois, Leven, Friendly Business. You can preview these changes by following the links below:
I will update this comment with the latest preview links as you push more changes to this PR. |
|
General visual observations Looks fantastic, love it. I like the subtle darker background in the gridded header area, the gridlines that invisibly extend from there, the small font, the all-caps, and even the typeface and spacing itself. This is a solid, fantastic theme. The demo content on the homepage is a little long. I understand it's a full script, but it might be nice to show just a subset, as I'm reviewing I'm not going to read it, I just want to see the footer 😅 Also, very personal nitpick (feel free to ignore as with all others), I prefer the word "Summary: " over "TLDR:" or "TL;DR:". Mobile looks fantastic too. I want to use this theme immediately. Template review Templates look good. The Four Oh Four in ASCII is a bit out there:
I think it's fun. I wonder what theme feedback will say regarding screen readers reading this aloud, you might get pushback. If that happens and you have to remove that ASCII, it will not be the end of the world. The header navigation font looks different in Playground from the demo site:
It looks okay on the frontend, so curious what this is. It may be nothing? Style variations Style variations look good. I appreciate you included some type changes. The default color style, warm white or beige, works great for this. Pink, blue and green, less so.
I had expected some monochrome variations. One that has a pure white background. Perhaps one with a pure black background. perhaps one with a gray background, or even a super dark gray background, maybe even a warm-gray dark background. Quick test:
File and readme reviews Readme and licenses look good. Something is off with the font filenames again:
This is also a question for you, for may own education: what are these pattern files? They look like theme template files:
Summary This is a fantastic theme, it will be a hit. There are primarily some technical details to tweak, let me know if I can help there. Then there's the open question of whether to stress the style variations a little bit. Not a blocker, but given how lovely this is, perhaps worth a shot? Nice work! |
@jasmussen, the preview links are bugged again, as you can see. I didn't touch any of those themes, but they are there. Should I merge this PR or create a new one? I know you mentioned the first, I just want to confirm it here; thank you. |
|
Fantastic followup. Changeset looks great, changes look great. This one is ready! Feel free to press the button, and nice work! |
Stageplay is a blog theme that ideally suits writers and the general public who want their sites formatted as scripts.
Demo site