Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler: Add two new typography styles #7977

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

alaczek
Copy link
Contributor

@alaczek alaczek commented Jul 30, 2024

Proposing two new font combos:

  • Playfair Display + Figtree
  • Rubik + Tilda Sans

I came up with these two font combos while working on ready made templates.

The Playfair Display + Figtree is meant to complement our offering of elegant font pairings.
The Rubik + Tilda Sans is a combo I grabbed from the Cortado theme (swapping Plus Jakarta Sans for Tilda).

Playfair Display + Figtree Rubik + Tilda Sans
image image

cc @richtabor

Proposing two new font combos:
* Playfair Display + Figtree
* Rubik + Tilda Sans
Copy link
Contributor

github-actions bot commented Jul 30, 2024

Preview changes

I've detected changes to the following themes in this PR: Assembler.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@richtabor
Copy link
Contributor

I'm not getting the Playfair Display to work here?

CleanShot 2024-08-02 at 16 41 24

@richtabor
Copy link
Contributor

Looks like fonts aren't loading properly for either.

I see, we need to register them in theme.json, like the other fonts.

CleanShot 2024-08-02 at 16 42 10

@richtabor
Copy link
Contributor

@beafialho what do you think of these font combinations?

Add font declarations.
@alaczek
Copy link
Contributor Author

alaczek commented Aug 6, 2024

I see, we need to register them in theme.json, like the other fonts.

Yep, I totally forgot to push the updated theme.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants