Update theme goodskin

[beafialho]

Addresses comments from: https://themes.trac.wordpress.org/ticket/185480

[beafialho]

After submitting Goodskin to WordPress.org, I got a number of comments, some of which I was able to address. The others are listed below.

Warnings
WARNING: Found ="<?php esc_html_e in patterns/home.php. Use esc_attr_e() inside HTML attributes, and esc_url() for link attributes. A manual review is needed.
WARNING: Found ="<?php esc_html_e in patterns/two-column-gallery.php. Use esc_attr_e() inside HTML attributes, and esc_url() for link attributes. A manual review is needed.

Skip Links

Check skip links requirement here. https://make.wordpress.org/themes/handbook/review/required/#skip-links
Recommended reading, https://make.wordpress.org/themes/2019/07/14/how-to-add-and-test-skip-links/
It is hiding the first post. Check it properly.

Extras

Broken block found in the editor, https://i.rankmath.com/i/3sz1z4
Check theme.json error, https://prnt.sc/9NDDpv44e0KC

Translation
Translation missing on about-page-heading-paragraph-image.php file. Check other patterns file too.

[github-actions]

Preview changes

I've detected changes to the following themes in this PR: Goodskin.

You can preview these changes by following the links below:

• Preview changes for Goodskin

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

[jasmussen]

I'm curious why this PR is already out of date with trunk, and needs a rebase. Bea did you pull latest changes before making this update?

As for the changes in particular, I'll unfortunately have to ask for help from @vcanales, @madhusudhand, @mikachan or @matiasbenedetto. Did Bea use CBT wrong here, as far as the templates that were put in the patterns directory? Or is there a CBT fix to make?

[beafialho]

Bea did you pull latest changes before making this update?

I do not use the GH desktop app. What I did was download the latest version of the theme, add it to WP Playground, save my changes and export to a new PR 🤔

[vcanales]

Did Bea use CBT wrong here, as far as the templates that were put in the patterns directory? Or is there a CBT fix to make?

I do not use the GH desktop app. What I did was download the latest version of the theme, add it to WP Playground, save my changes and export to a new PR 🤔

The best way to ensure that PRs for previews work well is to get the latest code from GitHub, because we could have made changes to a theme without deploying them, which is what I think happened in this PR.

@beafialho would it be possible to create another PR following a workflow where the changes you make to the theme are made to the latest code stored GitHub? I'm asking because the conflicts we see here make it hard to determine what to keep. If you need any help figuring out a workflow that will make it easier to review your themes, please reach out to me here on in private!

[madhusudhand]

Since the theme already in trunk, it should be showing differences of files such as style.css, theme.json

But it shows them as new changes.

@beafialho can you try merging latest trunk into this branch?

[madhusudhand]

@jasmussen can you suggest on the following review comment from dotOrg?

Images created from Modjourney is not GPL compatible too and we won't allow to use fully AI generated images. Check meeting notes here, https://make.wordpress.org/themes/2023/08/10/themes-team-meeting-notes-august-08-2023/

[madhusudhand]

Since the theme already in trunk, it should be showing differences of files such as style.css, theme.json

But it shows them as new changes.

@beafialho can you try merging latest trunk into this branch?

Resolved conflicts and addressed dotOrg feedback.

[jasmussen]

Thanks so much. I'll need to ask some folks about the Midjourney issue.

[alaczek]

Thanks so much. I'll need to ask some folks about the Midjourney issue.

Thanks for looking into this @jasmussen . Please share the outcome on a p2 or somewhere with broader visibility!