Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aigoo #8049

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Add Aigoo #8049

wants to merge 1 commit into from

Conversation

scruffian
Copy link
Member

@scruffian scruffian commented Sep 2, 2024

pNEWy-hLq-p2

Aigoo is a theme for K-Pop enthusiasts.

aigoo.WordPress.2024-09-16.xml.zip

@scruffian scruffian self-assigned this Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Preview changes

I've detected changes to the following themes in this PR: Aigoo.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The categories pattern has a few images that need to be brought into the theme, as well as missing alt text

<!-- wp:columns {"align":"wide"} -->
<div class="wp-block-columns alignwide"><!-- wp:column -->
<div class="wp-block-column"><!-- wp:cover {"url":"https://kpop.mystagingwebsite.com/wp-content/themes/aigoo/assets/images/image_6-scaled.jpg","id":71,"dimRatio":30,"overlayColor":"black","minHeight":260,"contentPosition":"bottom left","style":{"elements":{"link":{"color":{"text":"var:preset|color|base"}}},"spacing":{"padding":{"top":"var:preset|spacing|60","bottom":"var:preset|spacing|60","left":"var:preset|spacing|60","right":"var:preset|spacing|60"}}},"textColor":"base"} -->
<div class="wp-block-cover has-custom-content-position is-position-bottom-left has-base-color has-text-color has-link-color" style="padding-top:var(--wp--preset--spacing--60);padding-right:var(--wp--preset--spacing--60);padding-bottom:var(--wp--preset--spacing--60);padding-left:var(--wp--preset--spacing--60);min-height:260px"><span aria-hidden="true" class="wp-block-cover__background has-black-background-color has-background-dim-30 has-background-dim"></span><img class="wp-block-cover__image-background wp-image-71" alt="" src="https://kpop.mystagingwebsite.com/wp-content/themes/aigoo/assets/images/image_6-scaled.jpg" data-object-fit="cover"/><div class="wp-block-cover__inner-container"><!-- wp:paragraph {"align":"center","fontSize":"medium"} -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

External images should be escaped. I think this one also needs alt text.

@MaggieCabrera MaggieCabrera added Ready to launch Add this label if this is the first PR for a new theme and removed Ready to launch Add this label if this is the first PR for a new theme labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants