-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Professio: add theme #8462
Professio: add theme #8462
Conversation
Preview changesI've detected changes to the following themes in this PR: Professio. I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
@iamtakashi, please let me know how to fix the background images. CBT needs to link images better on the cover block. |
Interesting. I'm testing CBT to find out when it fails to localise. Because CBT correctly did it for some of the cover block instance in the theme. |
@henriqueiamarino I've pushed a fix for the cover blocks. It looks like lots of changes, but I've just changed the URL of the background image from And move the content of each template to a pattern because we need to use the PHP function Pull my change by running |
It looks like CBT fails to localise the image in a cover block when one (or both) of the settings is on. I've created an issue for it. WordPress/create-block-theme#748 I'll continue reviewing the theme. |
Thanks, @iamtakashi. I pulled the changes as you asked me to. |
@henriqueiamarino The theme is solid! I only noticed a few things.
|
Thanks, @iamtakashi. I've checked and fixed the following issues:
|
Theme-Check resultsprofessio: No changes required ✅. |
Thanks for the update, @henriqueiamarino. I forgot to mention removing the Time to Read pattern from the JSON, and I just pushed a change myself now. The theme looks good to me. Ship it 🚢 ! |
Professio is created for individual teachers based on Annalee, a theme designed for personal coaches.
Demo site | Site content