Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Professio: add theme #8462

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Professio: add theme #8462

merged 4 commits into from
Nov 29, 2024

Conversation

henriqueiamarino
Copy link
Collaborator

Professio is created for individual teachers based on Annalee, a theme designed for personal coaches.

Demo site | Site content

screenshot

@henriqueiamarino henriqueiamarino added the Ready to launch Add this label if this is the first PR for a new theme label Nov 26, 2024
@henriqueiamarino henriqueiamarino self-assigned this Nov 26, 2024
Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Professio.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@henriqueiamarino henriqueiamarino mentioned this pull request Nov 26, 2024
@henriqueiamarino
Copy link
Collaborator Author

@iamtakashi, please let me know how to fix the background images. CBT needs to link images better on the cover block.
I remember having the same issue on #7890, but I couldn't fix this one using the previous solution.

@iamtakashi iamtakashi self-assigned this Nov 26, 2024
@iamtakashi
Copy link
Contributor

CBT needs to link images better on the cover block.

Interesting. I'm testing CBT to find out when it fails to localise. Because CBT correctly did it for some of the cover block instance in the theme.

@iamtakashi
Copy link
Contributor

@henriqueiamarino I've pushed a fix for the cover blocks. It looks like lots of changes, but I've just changed the URL of the background image from
http://localhost.local/wp-content/themes/professio/assets/images/StockSnap_ESDCTK2C7Z_web.png
to
<?php echo esc_url( get_template_directory_uri() ); ?>/assets/images/StockSnap_ESDCTK2C7Z_web.png
so it works on any site.

And move the content of each template to a pattern because we need to use the PHP function get_template_directory_uri().

Pull my change by running git pull from this brunch, add/professio so you update your local copy with my change.

@iamtakashi
Copy link
Contributor

iamtakashi commented Nov 27, 2024

It looks like CBT fails to localise the image in a cover block when one (or both) of the settings is on. I've created an issue for it. WordPress/create-block-theme#748

I'll continue reviewing the theme.

CleanShot 2024-11-26 at 23 52 08@2x

@henriqueiamarino
Copy link
Collaborator Author

Thanks, @iamtakashi. I pulled the changes as you asked me to.

@iamtakashi
Copy link
Contributor

@henriqueiamarino The theme is solid! I only noticed a few things.

  • Let's add the usual phrase for the query no results blocks on the archive, index, search, and home templates.
  • Let the row block with the links and credit in the footer wrap to multiple lines for small screens.
    CleanShot 2024-11-27 at 17 56 56@2x
  • Let's remove the term description block from the search results template. It will not print anything on the template.
  • Remove these unused template parts,parts/footer-simple.html and parts/time-to-read.html.
  • Remove these unused patterns, patterns/no-results-content.php, patterns/services.php, patterns/testimonials.php, patterns/time-to-read.php, patterns/video.php

@henriqueiamarino
Copy link
Collaborator Author

Thanks, @iamtakashi. I've checked and fixed the following issues:

  • I added our default indicative sentence to the no-results block: Home, Archive, Index, and Search results;
  • I allowed the last Footer block to wrap to multiple lines;
  • I deleted the description block from the Search results template;
  • I removed the unused template parts: footer-simple and time-to-read;
  • I removed the unused patterns: no-results-content, services, testimonials, time-to-read, and video.

Copy link
Contributor

Theme-Check results

professio: No changes required ✅.


@iamtakashi
Copy link
Contributor

Thanks for the update, @henriqueiamarino. I forgot to mention removing the Time to Read pattern from the JSON, and I just pushed a change myself now.

The theme looks good to me. Ship it 🚢 !

@henriqueiamarino henriqueiamarino merged commit f91985e into trunk Nov 29, 2024
3 checks passed
@henriqueiamarino henriqueiamarino deleted the add/professio branch November 29, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants