Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MCCY] Round prices to nearest lowest denominator instead of rounding up before applying mccy rounding settings #10009

Open
reykjalin opened this issue Dec 20, 2024 · 0 comments · May be fixed by #9932
Open

[MCCY] Round prices to nearest lowest denominator instead of rounding up before applying mccy rounding settings #10009

reykjalin opened this issue Dec 20, 2024 · 0 comments · May be fixed by #9932
Assignees
@reykjalin
Labels
focus: multi-currency type: enhancement The issue is a request for an enhancement.

Comments

@reykjalin
Copy link
Contributor

Description

As discussed in paJDYF-g0K-p2 we consider round to be a better approach than ceil, so we need to change the functionality implemented in #9876 to use round instead of ceil to round prices before they're passed on to the rounding functions that use the mccy settings.

Acceptance criteria

  • Prices are rounded to the nearest lowest denominator for every currency before they're passed on to the rounding functions that use the mccy settings.

Dev notes

Additional context
@reykjalin reykjalin added focus: multi-currency type: enhancement The issue is a request for an enhancement. labels Dec 20, 2024
@reykjalin reykjalin self-assigned this Dec 20, 2024
@reykjalin reykjalin linked a pull request Dec 20, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reykjalin reykjalin

Labels
focus: multi-currency type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
1 participant
@reykjalin