MCCY: Round to lowest denomination before applying price rounding from MCCY settings #9932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
…ings This is consistent with the results of the discussions in paJDYF-g0K-p2. Previous behavior as of #9876 is to ceil the price before applying any rounding options from the settings, but based on the P2 discussions we identified that using `round` instead of `ceil` is the better approach.
reykjalin
force-pushed
the
add/round-to-nearest-lowest-denomination-before-applying-rounding-from-settings
branch
from
d971558 to
ff38f59
Compare
reykjalin
requested review from
a team and
bborman22
and removed request for
a team
bborman22
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
This tested very well and matched all the expectations. I included a table of the scenarios I tested below to cover product types, quantities, price rounding, and price charming settings. The only note I had was that with JPY, since the price rounding options only goes to 1 (not 0) it essentially always uses a ceiling. I believe this is the desired behavior given the zero decimal aspect, but wanted to confirm that with you.
EUR using a conversion rate of 3.783325
| Product Type | Price | Single Item Conversion | Quantity | Quantity Conversion | Using Round | Rounding 0.5, Charm None | Rounding None, Charm -0.01 | Rounding 1.0, Charm -0.01 |
|---|---|---|---|---|---|---|---|---|
| Deposit | 25 | 94.583125 | 1 | 94.583125 | 94.58 | 95 | 94.57 | 94.99 |
| Subscription | 10 | 37.83325 | 1 | 37.83325 | 37.83 | 38 | 37.82 | 37.99 |
| Subscription Sign Up Fee | 2 | 7.56665 | 1 | 7.56665 | 7.57 | 8 | 7.56 | 7.99 |
| Simple Product | 18.5 | 69.9915125 | 1 | 69.9915125 | 69.99 | 70 | 69.98 | 69.99 |
| Simple Product | 18.3 | 69.2348475 | 1 | 69.2348475 | 69.23 | 69.5 | 69.22 | 69.99 |
| Deposit | 25 | 94.583125 | 20 | 1891.6625 | 1891.6 | 1900 | 1891.4 | 1899.8 |
| Subscription | 10 | 37.83325 | 20 | 756.665 | 756.6 | 760 | 756.4 | 759.8 |
| Subscription Sign Up Fee | 2 | 7.56665 | 20 | 151.333 | 151.4 | 160 | 151.2 | 159.8 |
| Simple Product | 18.5 | 69.9915125 | 20 | 1399.83025 | 1399.8 | 1400 | 1399.6 | 1399.8 |
| Simple Product | 18.3 | 69.2348475 | 20 | 1384.69695 | 1384.6 | 1390 | 1384.4 | 1399.8 |
JPY using a conversion rate of 147.37782
| Product Type | Price | Single Item Conversion | Using Ceil | Rounding 50, Charm None | Rounding 1, Charm -1 | Rounding 100, Charm -1 |
|---|---|---|---|---|---|---|
| Deposit | 25 | 3684.4455 | 3685 | 3700 | 3684 | 3699 |
| Subscription | 10 | 1473.7782 | 1474 | 1500 | 1473 | 1499 |
| Subscription Sign Up Fee | 2 | 294.75564 | 295 | 300 | 294 | 299 |
| Simple Product | 18.5 | 2726.48967 | 2727 | 2750 | 2726 | 2799 |
| Simple Product | 18.3 | 2697.014106 | 2698 | 2700 | 2697 | 2699 |
I had one minor nit on reusing a value, but it's not a blocker in my opinion. Otherwise this all looks good to me!
…before-applying-rounding-from-settings
@bborman22, yes that is expected behavior if the rounding is set to |
bborman22
approved these changes
Jan 7, 2025
reykjalin
deleted the
add/round-to-nearest-lowest-denomination-before-applying-rounding-from-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10009
Changes proposed in this Pull Request
This is consistent with the results of the discussions in paJDYF-g0K-p2.
Previous behavior as of #9876 is to ceil the price before applying any rounding options from the settings, but based on the P2 discussions we identified that using
roundinstead ofceilis the better approach.Testing instructions
Then;
Note
You must have the WooCommerce Deposits plugin active and enabled.
3.783325.noneand "price rounding" to0.00.94.5894.58.Finally;
EURandJPY, and make sure rounding is consistently applied.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge