-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "currency conversion fee" #10002
Conversation
Fixes 9996
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: +73 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes are straightforward string replacements and do not affect any code logic. They look good to me. Snapshots are updated and unit tests pass. I have left a tiny optional suggestion for the changelog since it features on our public release note.
Fixes #9996
Changes proposed in this Pull Request
Use "currency conversion fee", not "foreign exchange fee". This is for a couple reasons:
The changes here should not break anything, as they are entirely string changes.
Other notes:
FX
or similar. There are tons of these, and what I'm most concerned about with this PR is merchant-facing content.