refactor: ECE refreshes blocks UI in all scenarios #10024
+32
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +122 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
frosso
requested review from
a team,
gpressutto5,
asumaran and
rafaelzaleski
and removed request for
a team
|
@asumaran @rafaelzaleski 👋 pinging y'all since you were involved in the UI refresh implementation in #9888 - I'd like to hear your thoughts :) Thank you! |
gpressutto5
approved these changes
Dec 23, 2024
This is a great solution for refreshing the UI since the backend already has the updated data. Awesome work! 👏 |
asumaran
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this Pull Request
I'd like to propose a slight alternative to #9888 .
I noticed that if you have multiple shipping options, and you interact with them, when the dialog is dismissed the selected shipping option might not be accurate.
Let's take this example:
The solution I'm proposing creates a "bogus" endpoint in the backend, which can be hit w/ the Block API's
extensionCartUpdate, so that the UI is refreshed with new data (which includes the selected shipping rate, and the anonymized address for UK and CA.This only applies to the blocks checkout, because it gives us this opportunity.
Testing instructions
Note
In case of UK or CA addresses, the ZIP code displayed will be the same that would be displayed if the customer just refreshed the page. We were preventing the submission of UK and CA addresses only because the API would fail. But the address was updated anyways.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge