Fix GPay button missing in Safari #9266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +14 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
rafaelzaleski
requested review from
a team and
lovo-h
and removed request for
a team
lovo-h
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Code changes look good and test well 👍
Testing Instructions
- 🟢 On the
developbranch, verify that only the Apple Pay button is visible by visiting the Blocks checkout page with a product in the cart using Safari. - 🟢 On the
fix/9202-ece-gpay-missing-on-safaribranch, repeat the test, and confirm that both the Apple Pay and GPay buttons are now displayed in Safari. - 🟢 In the admin area, go to the Express Checkout preview in the WooPayments settings and confirm that both buttons are shown in Safari.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9202
Changes proposed in this Pull Request
This update fixes the missing Google Pay (GPay) button in Safari in the blocks checkout and cart pages.
The issue occurred because the shortcode checkout had Apple Pay and Google Pay always enabled, while the Blocks version left Stripe to decide, causing the GPay button to not appear.
Testing instructions
To test the changes, follow these steps on a publicly accessible URL and an HTTPS-enabled website:
developbranch, verify that only the Apple Pay button is visible by visiting the Blocks checkout page with a product in the cart using Safari.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge