Use paragraph selector instead of label for pmme appearance #9840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +371 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
gpressutto5
requested review from
a team and
danielmx-dev
and removed request for
a team
|
@pierorocca, Could you please take a look to see if it looks better now? |
|
@gpressutto5 Can you please share which theme you are using and which customizations (colors, additional CSS) are set? I'm having some issues replicating the behavior locally. |
|
@danielmx-dev I'm using Storefront with this additional css: * {
background-color: #4342da;
color: white;
}
a {
color: white !important;
} |
Thanks, the only thing that I was missing was clearing the transients between branch changes. I'm able to replicate the issue now. |
danielmx-dev
approved these changes
Nov 28, 2024
|
Colors looks good. Is the font sizing being addressed in the other PRs? |
|
@pierorocca Yes, because #9818 aims to set a custom size for this text there's no need to understand what is causing the size inconsistencies from this comment here. |
jaclync
added a commit
that referenced
this pull request
Dec 2, 2024
* develop: Ensure ECE button load events are triggered for multiple buttons on the same page (#9845) Payouts: Add payout bank reference key to payout reports and CSV (#9832) Fix WooPay component spacing (#9748) Use paragraph selector instead of label for pmme appearance (#9840) Allow redirect to the settings page from WCPay connect (#9827) Update references to woocommerce_payments_server (#9824) Fix return types in DocBlocks (#9815) Fix WooPay trial subscriptions purchases (#9778)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9803
Changes proposed in this Pull Request
We were using the Label text styles for the
.Textclass for in Stripe Appearance API. This works well in the shortcode checkout because they have similar styles, but the Blocks checkout uses floating labels, so their style is very different from paragraph text.This PR updates the selector for all location, however it is noticeable only in the blocks checkout.
Testing instructions
develop, but it looks good in this branch.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge