i18n: Switch to POT generation

[akirk]

This is dependent on Automattic/xgettext-js#11 (merged) and Automattic/i18n-calypso#13 (merged). It allows us to generate a calypso-strings.pot that include the real source locations of the strings. For example:

#: wp-calypso/client/components/tinymce/plugins/after-the-deadline/core.js:234
#. Proofreading error description
msgid "Spelling"
msgstr ""

Fixes #5172

Side-effects: building calypso-strings.pot doesn't depend on webpack anymore so it's much faster standalone.

cc @rralian @yoavf

[akirk]

@gwwar I adapted the path from your script in #4949 but I don't know if there's another spot that needs a change for this.

[gwwar]

@akirk see the related pMz3w-5vb-p2 I don't know of any other hook points than this.

[deBhal]

We'll also need to update our version to pick up the two dependencies we rely on:

• update xgettext-js version
• update i18n-calypso version
• Shrinkwrap

[gwwar]

@deBhal when updating package.json, please run make shrinkwrap and commit the changes.

[deBhal]

We're going to have to update the i18n-calypso version as well, but I'll add another checkbox so I don't forget to do it after that. Thanks for the reminder :)

[akirk]

To test:

1. make distclean translate
2. check that a calypso-strings.pot was generated and is valid (open in text editor or PO Edit)
   (3. Creation of the artifact calypso-strings.pot will only happen on master commits)

Thanks!

[aduth]

Do we need to ignore this anymore?

[akirk]

You're right, I left it in to avoid complaints about left-over calypso-strings.php but the CircleCI builds are generated fresh anyway.

[aduth]

So I'm trying to follow the old server/bin/list-assets.js . At the very least, I don't think you need CALYPSO_ENV=stage here anymore, as this was driving which assets file was loaded in the list-assets script. What I haven't been able to determine yet is whether those files were generated for the sole purpose of i18n and can be further cleaned up.

[akirk]

Interesting observation, though determining this is possibly outside the scope of this PR.

[aduth]

The assets files are used for looking up bundled script locations by chunk, so they'll need to remain. That being said, there's some change in behavior here then, as previously I18N_CALYPSO was run on the built scripts, and are now being run on the source files. Is that okay?

[aduth]

Interesting observation, though determining this is possibly outside the scope of this PR.

It's within scope if your changes cause files or logic to become unused 😄

[akirk]

Yeah, that's part of the reason we are doing this. We want to reference the real string location which was not possible when generating from the built scripts.

[aduth]

LGTM 👍

[akirk]

Thanks everyone!