Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more mui classes for buttons #2159

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

JeevaRamanathan
Copy link
Contributor

Address #588
Added size and variant for the button, along with testcase and example. Please let me know if this is on the right track and required any changes.

Signed-off-by: JeevaRamanathan M <[email protected]>
Signed-off-by: JeevaRamanathan M <[email protected]>
@FlorianJacta FlorianJacta added 📈 Improvement Improvement of a feature. 🖰 GUI Related to GUI labels Oct 28, 2024
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the viselements.json file should be also impacted.

taipy/gui/_renderers/factory.py Outdated Show resolved Hide resolved
frontend/taipy-gui/src/components/Taipy/Button.tsx Outdated Show resolved Hide resolved
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tx

@JeevaRamanathan
Copy link
Contributor Author

Hi @FredLL-Avaiga, the changes have been made. Please have a look based on your time.

@FredLL-Avaiga
Copy link
Member

We're discussing with @FabienLelaquais what should be done ...

@JeevaRamanathan
Copy link
Contributor Author

@quest-bot loot #588

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 30, 2024
Copy link

quest-bot bot commented Oct 30, 2024

Quest PR submitted! image Quest PR submitted!

@JeevaRamanathan, you are attempting to solve the issue and loot this Quest. Will you be successful?


Questions? Check out the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI 📈 Improvement Improvement of a feature. ⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants