Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #558 add matplotlib example #2179

Merged

Conversation

AbisoyeOnanuga
Copy link
Contributor

@AbisoyeOnanuga AbisoyeOnanuga commented Oct 28, 2024

Hello @jrobinAV if this is still open for PRs

This pull request adds a new example demonstrating how to integrate Matplotlib scatter plots within the Taipy framework using markdown syntax. The example showcases the creation of a scatter plot representing employee performance vs. happiness, with bubble sizes indicating efficiency.

  • The legend displays efficiency percentages.
  • Custom CSS is applied to ensure a responsive and well-aligned layout.

image

@AbisoyeOnanuga AbisoyeOnanuga changed the title Issue 558 add matplotlib example Issue #558 add matplotlib example Oct 30, 2024
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tx, great work

A few changes

Could you add a screenshot of the result as a comment to the PR?

doc/gui/examples/charts/matplotlib/styles.css Outdated Show resolved Hide resolved
doc/gui/examples/charts/matplotlib/matplotlib_scatter.py Outdated Show resolved Hide resolved
doc/gui/examples/charts/matplotlib/matplotlib_scatter.py Outdated Show resolved Hide resolved
doc/gui/examples/charts/matplotlib/styles.css Outdated Show resolved Hide resolved
@AbisoyeOnanuga
Copy link
Contributor Author

Thanks for reviewing, I'll make these updates @FredLL-Avaiga

@FredLL-Avaiga
Copy link
Member

and please fix the linter issues

@AbisoyeOnanuga
Copy link
Contributor Author

@FredLL-Avaiga below is the screenshot of the most recent commit to the PR after my update to Taipy 4.0.0 as of now
image

@FredLL-Avaiga FredLL-Avaiga self-requested a review November 2, 2024 11:49
@AbisoyeOnanuga
Copy link
Contributor Author

Hello @FredLL-Avaiga , I noticed that the linter error may still persist . This PR is a first for me i.e. contributing in Python and contributing for OpenSource, so it's hard to know what the issue was. I would be interested in learning from this. Thank you

@FredLL-Avaiga
Copy link
Member

Hello @FredLL-Avaiga , I noticed that the linter error may still persist . This PR is a first for me i.e. contributing in Python and contributing for OpenSource, so it's hard to know what the issue was. I would be interested in learning from this. Thank you

you can set the imports exactly as

import os

import matplotlib.pyplot as plt
from taipy.gui import Gui, Markdown

that should fix the linter sort imports issue

import matplotlib.pyplot as plt
from taipy.gui import Gui, Markdown


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove one line here

Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrobinAV Good for HacktoberFest Merge

@jrobinAV jrobinAV merged commit ad79eef into Avaiga:develop Nov 13, 2024
53 of 56 checks passed
@jrobinAV jrobinAV added hacktoberfest hacktoberfest issues hacktoberfest - 300💎💎💎 Issues rewarded by 300 points labels Nov 13, 2024
@AbisoyeOnanuga
Copy link
Contributor Author

AbisoyeOnanuga commented Nov 13, 2024

I've enjoyed learning through this experience, as well as the incredible support from the Taipy. Thank you guys for pointing out the issues I needed to fix, thereby sharpening my fundamentals of making Pull Requests, including:-

  • updating libraries,
  • code consistency,
  • filenaming conventions,
  • sorting package imports
  • reducing complexity ,etc.
    cheers to @FredLL-Avaiga -- @jrobinAV -- @RymMichaut --@FabienLelaquais for strengthening the developer community and sponsoring Hacktoberfest!
    Thanks @SGCODEX for leading the way on this endeavor

@jrobinAV
Copy link
Member

Thank you, @AbisoyeOnanuga, for your help and contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 Documentation Internal or public documentation 🖰 GUI Related to GUI hacktoberfest - 300💎💎💎 Issues rewarded by 300 points ✅ hacktoberfest: approved An approved PR for Hacktoberfest rewarding hacktoberfest hacktoberfest issues 🟩 Priority: Low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants