feat: Allow Name Generator to disable attach to DevTools #14425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
reviewed
Jan 31, 2024
| @@ -50,7 +50,7 @@ | |||
| <BoolProperty Name="AvaloniaNameGeneratorIsEnabled" | |||
| DisplayName="Use Name Generator" | |||
| Description="Enable/Disable Avalonia Name Source Generator" | |||
| HelpUrl="https://github.com/AvaloniaUI/Avalonia/blob/master/src/tools/Avalonia.Generators/README.md" | |||
| HelpUrl="https://github.com/AvaloniaUI/Avalonia/blob/master/src/tools/Avalonia.Generators/README.md#advanced-usage" | |||
There was a problem hiding this comment.
Side note: it should be moved to the docs page.
maxkatz6
approved these changes
Jan 31, 2024
workgroupengineering
deleted the
features/Tools/Generators/AvaloniaName/Allow-disable-attach-to-DevTools
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Add property
AvaloniaNameGeneratorAttachDevToolsto Name Generaator that allow it to disable attach to DevToolsWhat is the current behavior?
Name Generaatorif the target isWindow, the DEBUG constant is defined and the project referencesAvalonia.Diagnostics, always generate code for Attach to DevTools. This behavior does not allow you to easily customize DevTools options. To do this you need to modify each window constructor to invokeInitializeComponent(attachDevTools: false);instead ofInitializeComponent();.What is the updated/expected behavior with this PR?
When add following to .csproj does not generate code to Attach to DevTools
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues