Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate selection_str #891

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Deprecate selection_str #891

merged 1 commit into from
Sep 12, 2024

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

Close: #889

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@coveralls
Copy link

Coverage Status

coverage: 90.239% (+0.01%) from 90.228%
when pulling 56d286b on no_selection_str
into c079ffd on master.

@dachengx dachengx marked this pull request as ready for review September 12, 2024 15:48
@dachengx dachengx merged commit d4964b6 into master Sep 12, 2024
8 checks passed
@dachengx dachengx deleted the no_selection_str branch September 12, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

selection_str should be deprecated
2 participants