-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does react-oidc support RFC 8707 (Resource indicator) #937
Comments
hi @Annouar , It should already work with one resource with that kind of configuration using extras parameter: const configuration = {
client_id: 'interactive.public.short',
redirect_uri: window.location.origin + '/authentication/callback',
silent_redirect_uri: window.location.origin + '/authentication/silent-callback', // Optional activate silent-signin that use cookies between OIDC server and client javascript to restore the session
scope: 'openid profile email api offline_access',
authority: 'https://demo.duendesoftware.com',
service_worker_relative_url:'/OidcServiceWorker.js',
service_worker_only:true,
extras:{
'resource:token_request': 'https://www.guillaume-chervet.fr'
resource: 'https://www.guillaume-chervet.fr'
}
}; I have to make an evolution ta make possible to add multiple resources. May be like: const configuration = {
client_id: 'interactive.public.short',
redirect_uri: window.location.origin + '/authentication/callback',
silent_redirect_uri: window.location.origin + '/authentication/silent-callback', // Optional activate silent-signin that use cookies between OIDC server and client javascript to restore the session
scope: 'openid profile email api offline_access',
authority: 'https://demo.duendesoftware.com',
service_worker_relative_url:'/OidcServiceWorker.js',
service_worker_only:true,
extras:{
'resource:token_request': 'https://www.guillaume-chervet.fr/toto,https://www.guillaume-chervet.fr/youhou'
resource: 'https://www.guillaume-chervet.fr/toto,https://www.guillaume-chervet.fr/youhou'
}
}; |
Oh, I haven't seen it require to remove scope parameter. I may have to make some évolution. |
Hey @guillaume-chervet ! To be honest, I am super interested in the evolution to make possible adding multiple resources. What about pass the resources as an array ? I was also wondering the way we need to programmatically Anyway, if you need some help for the testing the feature, feel free to ask ;) |
Thank you @Annouar , |
Many reason why : - appauthjs code is complexe for few feature - it will be easier to setup simple unit test - appauthjs prevent to set up fast new oidc and oauth feature le Does react-oidc support RFC 8707 (Resource indicator) #937 - ligther bundle - it will be easier to clean the code and i need to - I want to ask openid for a certification - and also for security i want to hide codeverifier from client inside serviceworker, it will be unretrivable from the client
Hey @guillaume-chervet ! Hope you're well ! Feel free to ask ! |
Hi @Annouar , i will try to implement it tomorrow. I would like some help to test it, i havent oidc server configured with this available. Which oidc server do you use? |
Sorry @Annouar , i did not get the time to do it. I think it is simple to do now (few line of code). |
Hey @guillaume-chervet, Sorry, I've missed your previous message ! Enjoy your holidays ! |
Sorry @Annouar , I'am still on the subject, I do not forget your need. |
Issue and Steps to Reproduce
Hello everyone !
Thanks for this useful library !
I was wondering if the lib does support the Resource Indicator parameter (RFC 8707), or if it's planned to support it ?
I was looking for the information, but I did not find any reference to that kind of parameter in code or in documentation.
Thanks a lot :)
Annouar
Versions
6.13.1
The text was updated successfully, but these errors were encountered: