Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oidc): remove appauthjs library #939

Merged
merged 11 commits into from
Feb 1, 2023
Merged

feat(oidc): remove appauthjs library #939

merged 11 commits into from
Feb 1, 2023

Conversation

guillaume-chervet
Copy link
Contributor

Work in progress

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-glacier-004ab4303-939.westeurope.2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-rock-0dc6b0d03-939.westeurope.1.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-glacier-004ab4303-939.westeurope.2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-rock-0dc6b0d03-939.westeurope.1.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-glacier-004ab4303-939.westeurope.2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-rock-0dc6b0d03-939.westeurope.1.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-glacier-004ab4303-939.westeurope.2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-rock-0dc6b0d03-939.westeurope.1.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-glacier-004ab4303-939.westeurope.2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-rock-0dc6b0d03-939.westeurope.1.azurestaticapps.net

@ghostd
Copy link
Contributor

ghostd commented Jan 17, 2023

Hi @guillaume-chervet,

Why are you removing AppAuthJS? To have one less dependency and reduce the final bundle? (i'm just a bit curious :))

@guillaume-chervet
Copy link
Contributor Author

guillaume-chervet commented Jan 17, 2023 •
edited
Loading

Many reason @ghostd :

  • appauthjs code is complexe for few feature
  • it will be easier to setup simple unit test
  • appauthjs prevent to set up fast new oidc and oauth feature le Does react-oidc support RFC 8707 (Resource indicator) #937
  • ligther bundle
  • it will be easier to clean the code and i need to
  • I want to ask openid for a certification
  • and also for security i want to hide codeverifier from client inside serviceworker, it will be unretrivable from the client

@ghostd
Copy link
Contributor

ghostd commented Jan 17, 2023 •
edited
Loading

Thanks for this clear answer :)

  • I want to ask openid for a certification

Wow, that would be great.

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-glacier-004ab4303-939.westeurope.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-glacier-004ab4303-939.westeurope.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-rock-0dc6b0d03-939.westeurope.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-rock-0dc6b0d03-939.westeurope.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-glacier-004ab4303-939.westeurope.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-glacier-004ab4303-939.westeurope.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-rock-0dc6b0d03-939.westeurope.1.azurestaticapps.net

@guillaume-chervet guillaume-chervet temporarily deployed to react-oidc February 1, 2023 17:01 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-glacier-004ab4303-939.westeurope.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-rock-0dc6b0d03-939.westeurope.1.azurestaticapps.net

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 6 Security Hotspots
Code Smell A 48 Code Smells

6.2% 6.2% Coverage
0.2% 0.2% Duplication

@guillaume-chervet guillaume-chervet merged commit 8683528 into master Feb 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature/removeappauthjs branch February 1, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillaume-chervet @ghostd