Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed illegal qualified name in member declaration on the Watcher.h file #182

Closed

Conversation

rmmoreira84
Copy link

@rmmoreira84 rmmoreira84 commented Jul 4, 2024

Removed the illegal qualified name in member declaration on the Watcher.h so that we can install nsfw on node 22.
Closes #181

@julianmesa-gitkraken
Copy link
Contributor

julianmesa-gitkraken commented Jul 4, 2024

Why no just remove Watcher:: in Watcher::isExcluded, Watcher::getWatchedPathFromHandle and Watcher::checkWatchedPath in file includes\win32\Watcher.h ?

@rmmoreira84
Copy link
Author

We thought of that, but I wasn't sure of the impact it could have. I will do the change. Thank you for the comment.

@rmmoreira84 rmmoreira84 changed the title Added warning (4596) to the disabled warnings Removed illegal qualified name in member declaration on the header file Jul 4, 2024
@rmmoreira84 rmmoreira84 changed the title Removed illegal qualified name in member declaration on the header file Removed illegal qualified name in member declaration on the Watcher.h file Jul 4, 2024
@julianmesa-gitkraken
Copy link
Contributor

Need to fix CI :(

@julianmesa-gitkraken
Copy link
Contributor

@rmmoreira84 To fix CI I have had to add the warning fix also.
So this PR contains also the fix.
So I will close this PR.

@rmmoreira84
Copy link
Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 22 C++20 compilation warning
2 participants