Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update httpotion and exvcr #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baxford
Copy link

@baxford baxford commented Jul 25, 2017

Hi,

thanks for the library.
I'm using this with Phoenix v1.3.0-rc2 and had some issues when running mix deps.get
This is just minor changes to update httpotion and exvcr
I also had some failing tests, which were fixed by changing:
https://github.com/Azdaroth/ex_bookingsync_api_client_v3/blob/master/lib/bookingsync_api_client_v3/client.ex#L168
from
headers[:link]
to
headers["link"]

Let me know if this looks ok :)

fix headers[:link] to headers["link"]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant