-
Notifications
You must be signed in to change notification settings - Fork 298
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[1 changes] chore: add end step for formatting workflow (noir-lang/no…
…ir#7070) feat(LSP): code action to import trait in a method call (noir-lang/noir#7066) feat!: Handle generic fields in `StructDefinition::fields` and move old functionality to `StructDefinition::fields_as_written` (noir-lang/noir#7067) chore(ci): Check various inliner aggressiveness setttings in Brillig reports (noir-lang/noir#7049) chore: reenable reports on rollup root circuits (noir-lang/noir#7061) fix: don't always select trait impl when verifying trait constraints (noir-lang/noir#7041) chore: mark some critical libraries as good again (noir-lang/noir#7065) fix: Reduce memory usage in mem2reg (noir-lang/noir#7053) feat: Allow associated types to be ellided from trait constraints (noir-lang/noir#7026) chore(perf): try using vec-collections's VecSet in AliasSet (noir-lang/noir#7058) chore: reduce number of iterations of `acvm::compiler::compile` (noir-lang/noir#7050) chore: add `noir_check_shuffle` as a critical library (noir-lang/noir#7056) chore: clippy warning fix (noir-lang/noir#7051) chore(ci): Unify compilation/execution report jobs that take averages with single runs (noir-lang/noir#7048) fix(nargo_fmt): let doc comment could come after regular comment (noir-lang/noir#7046) fix(nargo_fmt): don't consider identifiers the same if they are equal… (noir-lang/noir#7043) feat: auto-import traits when suggesting trait methods (noir-lang/noir#7037) feat: avoid inserting `inc_rc` instructions into ACIR (noir-lang/noir#7036) fix(lsp): suggest all possible trait methods, but only visible ones (noir-lang/noir#7027) chore: add more protocol circuits to reports (noir-lang/noir#6977) feat: avoid generating a new witness when checking if linear expression is zero (noir-lang/noir#7031) feat: skip codegen of zero iteration loops (noir-lang/noir#7030)
- Loading branch information
Showing
1,338 changed files
with
11,752 additions
and
82,399 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| f337992de96ef656681ebfc96a30c2c9c9b82a70 | ||
| 9471e28ad6f02bf2fae3782c3db68106b615595f |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| .actual.jsonl | ||
| .actual.jsonl.jq | ||
| .failures.jsonl.jq |
File renamed without changes.
File renamed without changes.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
20 changes: 20 additions & 0 deletions
20
noir/noir-repo/.github/critical_libraries_status/README.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Critical Libraries Status | ||
|
|
||
| This directory contains one `.failures.jsonl` file per external directory that is checked by CI. | ||
| CI will run the external repository tests and compare the test failures against those recorded | ||
| in these files. If there's a difference, CI will fail. | ||
|
|
||
| This allows us to mark some tests as expected to fail if we introduce breaking changes. | ||
| When tests are fixed on the external repository, CI will let us know that we need to remove | ||
| the `.failures.jsonl` failures on our side. | ||
|
|
||
| The format of the `.failures.jsonl` files is one JSON per line with a failure: | ||
|
|
||
| ```json | ||
| {"suite":"one","name":"foo"} | ||
| ``` | ||
|
|
||
| If it's expected that an external repository doesn't compile (because a PR introduces breaking changes | ||
| to, say, the type system) you can remove the `.failures.jsonl` file for that repository and CI | ||
| will pass again. Once the repository compiles again, CI will let us know and require us to put | ||
| back the `.failures.jsonl` file. |
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| #!/bin/bash | ||
| set -eu | ||
|
|
||
| # Usage: ./check_test_results.sh <expected.json> <actual.jsonl> | ||
| # Compares the output of two test results of the same repository. | ||
| # If any of the files doesn't exist or is empty, the script will consider that the test suite | ||
| # couldn't be compiled. | ||
|
|
||
| function process_json_lines() { | ||
| cat $1 | jq -c 'select(.type == "test" and .event == "failed") | {suite: .suite, name: .name}' | jq -s -c 'sort_by(.suite, .name) | .[]' > $1.jq | ||
| } | ||
|
|
||
| if [ -f $1 ] && [ -f $2 ]; then | ||
| # Both files exist, let's compare them | ||
| $(process_json_lines $2) | ||
| if ! diff $1 $2.jq; then | ||
| echo "Error: test failures don't match expected failures" | ||
| echo "Lines prefixed with '>' are new test failures (you could add them to '$1')" | ||
| echo "Lines prefixed with '<' are tests that were expected to fail but passed (you could remove them from '$1')" | ||
| exit -1 | ||
| fi | ||
| elif [ -f $1 ]; then | ||
| # Only the expected file exists, which means the actual test couldn't be compiled. | ||
| echo "Error: external library tests couldn't be compiled." | ||
| echo "You could rename '$1' to '$1.does_not_compile' if it's expected that the external library can't be compiled." | ||
| exit -1 | ||
| elif [ -f $2 ]; then | ||
| # Only the actual file exists, which means we are expecting the external library | ||
| # not to compile but it did. | ||
| echo "Error: expected external library not to compile, but it did." | ||
| echo "You could create '$1' with these contents:" | ||
| $(process_json_lines $2) | ||
| cat $2.jq | ||
| exit -1 | ||
| else | ||
| # Both files don't exists, which means we are expecting the external library not | ||
| # to compile, and it didn't, so all is good. | ||
| exit 0 | ||
| fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.