feat: update args hash to be a flat poseidon

[sirasistant]

We used before a sort of tree structure for args hash to make an incremental hash. Poseidon is incremental in noir, so we can get rid of it and just use a flat poseidon hash.

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (FeeJuice:_increase_public_balance): 42.8 (-68%)
• avm_simulation_time_ms (FPC:constructor): 48.5 (-34%)
• avm_simulation_time_ms (Token:mint_public): 242 (+461%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 48.2 (-81%)
• avm_simulation_time_ms (FPC:prepare_fee): 57.8 (-33%)
• avm_simulation_time_ms (Token:_increase_public_balance): 49.6 (+30%)
• avm_simulation_bytecode_size_in_bytes (Token:constructor): 7,451 (-30%)
• avm_simulation_bytecode_size_in_bytes (FPC:constructor): 4,853 (-39%)
• avm_simulation_bytecode_size_in_bytes (Token:transfer_public): 5,562 (-36%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,767	1,541	701	749 (-1%)	773
proof_construction_time_sha256_30_ms	11,519	3,067	1,361	1,421	1,461 (+1%)
proof_construction_time_sha256_100_ms	45,395	11,919 (+1%)	5,377	5,407	5,363
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	34.0	58.0 (-2%)	87.0
proof_construction_time_poseidon_hash_30_ms	1,537	416	199	225	267 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,674	1,505	669	726 (-1%)	749 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,612	8,260	15,524
l1_rollup_calldata_gas	52,816	97,584	186,812
l1_rollup_execution_gas	821,812	1,557,988	3,348,651
l2_block_processing_time_in_ms	251 (-2%)	442 (+2%)	793 (+2%)
l2_block_building_time_in_ms	9,173	18,036	36,145
l2_block_rollup_simulation_time_in_ms	9,173	18,036	36,145
l2_block_public_tx_process_time_in_ms	7,806	16,636	34,702

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,034	3,966 (+2%)
node_database_size_in_bytes	14,225,648	18,223,344
pxe_database_size_in_bytes	16,258	26,818

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	69.5	377 (+1%)	20,971	44,933	N/A
private-kernel-inner	138	685	71,782	45,067	N/A
private-kernel-reset-tiny	318 (-1%)	688	64,268	44,922	N/A
private-kernel-tail	149 (-1%)	129	50,548	57,178	N/A
base-parity	6.03	N/A	160	96.0	N/A
root-parity	35.5	N/A	73,964	96.0	N/A
base-rollup	2,084 (-1%)	N/A	189,128	664	N/A
block-root-rollup	42.1	N/A	58,217	2,448	N/A
public-kernel-setup	83.9 (-2%)	N/A	114,433	79,670	N/A
public-kernel-app-logic	98.0	N/A	114,251	79,670	N/A
public-kernel-tail	566	N/A	487,098	16,414	N/A
private-kernel-reset-small	289	N/A	66,345	45,629	N/A
private-kernel-tail-to-public	788	599 (-2%)	447,469	1,825	N/A
public-kernel-teardown	83.2 (-1%)	N/A	114,697	79,670	N/A
merge-rollup	20.3 (-1%)	N/A	38,182	664	N/A
undefined	N/A	N/A	N/A	N/A	104,865

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	342
ContractInstanceDeployer:deploy	1,408	11,731	18.2 (-4%)
MultiCallEntrypoint:entrypoint	1,920	11,731	421
FeeJuice:deploy	1,376	11,731	383 (-2%)
SchnorrAccount:constructor	1,312	11,731	62.7 (-2%)
SchnorrAccount:entrypoint	2,336	11,731	370
FeeJuice:claim	1,344	11,731	33.8 (-14%)
Token:privately_mint_private_note	1,280	11,731	70.9 (-6%)
FPC:fee_entrypoint_public	1,344	11,731	20.5 (-26%)
Token:transfer	1,312	11,731	205 (-5%)
Benchmarking:create_note	1,344	11,731	76.3 (-1%)
SchnorrAccount:verify_private_authwit	1,280	11,731	24.9 (-8%)
Token:unshield	1,376	11,731	489 (-9%)
FPC:fee_entrypoint_private	1,376	11,731	648 (-9%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	⚠️ 42.8 (-68%)	1,197
FeeJuice:set_portal	10.6 (+2%)	1,179
Token:constructor	256 (-9%)	⚠️ 7,451 (-30%)
FPC:constructor	⚠️ 48.5 (-34%)	⚠️ 4,853 (-39%)
FeeJuice:check_balance	37.2 (+1%)	1,004
Token:mint_public	⚠️ 242 (+461%)	2,122
Token:assert_minter_and_mint	⚠️ 48.2 (-81%)	1,434
AuthRegistry:set_authorized	45.7 (+1%)	501
FPC:prepare_fee	⚠️ 57.8 (-33%)	1,379
Token:transfer_public	27.5 (-5%)	⚠️ 5,562 (-36%)
FPC:pay_refund	39.9 (-9%)	1,915
Benchmarking:increment_balance	980	1,571
Token:_increase_public_balance	⚠️ 49.6 (+30%)	1,168
FPC:pay_refund_with_shielded_rebate	51.9	1,919

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.163 (-1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.17 (+1%)	3.84 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.113 (+1%)	0.108 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.1 (+1%)	17.7 (+1%)	30.8 (-4%)	61.3 (+5%)	113
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.106 (+1%)	0.103 (+1%)	0.0998 (-4%)	0.106 (+5%)	0.101
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.3 (+1%)	26.3 (+2%)	43.9	84.1 (+2%)	161 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	357	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.109	0.107 (+3%)	0.105 (-1%)	0.104 (+2%)	0.101 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.0	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	129	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.105	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,419	668,302

Transaction size based on fee payment method

| Metric | |
| - | |

[LeilaWang]

Nice!