feat: eccvm translator zk sumcheck #9199
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iakovenkos
changed the title
iakovenkos
commented
Oct 16, 2024
| @@ -65,8 +65,8 @@ void eccvm_prove(State& state) noexcept | |||
| }; | |||
| } | |||
|
|
|||
| BENCHMARK(eccvm_generate_prover)->Unit(kMillisecond)->DenseRange(10, 20); | |||
| BENCHMARK(eccvm_prove)->Unit(kMillisecond)->DenseRange(10, 20); | |||
| BENCHMARK(eccvm_generate_prover)->Unit(kMillisecond)->DenseRange(12, 18); | |||
There was a problem hiding this comment.
The proving is quite slow and the time grows somewhat predictably.
iakovenkos
commented
Oct 16, 2024
| std::get<0>(accumulator) += | ||
| ((z_perm + lagrange_first) * numerator_evaluation - (z_perm_shift + lagrange_last) * denominator_evaluation) * | ||
| scaling_factor; | ||
|
|
||
| // Contribution (2) | ||
| std::get<1>(accumulator) += (lagrange_last * z_perm_shift) * scaling_factor; | ||
| std::get<1>(accumulator) += lagrange_last_short * z_perm_shift_short * scaling_factor; |
There was a problem hiding this comment.
Small optimization: taken into account the fact that the second component of the accumulator is actually of a much smaller degree ( 2 )
iakovenkos
commented
Oct 16, 2024
| @@ -70,7 +70,7 @@ template <typename Flavor> void ECCVMRecursiveVerifier_<Flavor>::verify_proof(co | |||
| gate_challenges[idx] = transcript->template get_challenge<FF>("Sumcheck:gate_challenge_" + std::to_string(idx)); | |||
| } | |||
|
|
|||
| auto [multivariate_challenge, claimed_evaluations, sumcheck_verified] = | |||
| auto [multivariate_challenge, claimed_evaluations, libra_evaluations, sumcheck_verified] = | |||
There was a problem hiding this comment.
here, the sumcheck verifier is getting evaluations of univariates that are used to mask sumcheck round univariates
iakovenkos
commented
Oct 16, 2024
| transcript->send_to_verifier("Libra:evaluations", zk_sumcheck_data.libra_evaluations); | ||
| for (size_t idx = 0; idx < multivariate_d; idx++) { | ||
| const FF& libra_evaluation = zk_sumcheck_data.libra_evaluations[idx]; | ||
| std::string libra_evaluation_label = "Libra:evaluation_" + std::to_string(idx); |
There was a problem hiding this comment.
fixed a discrepancy in the way the prover and the verifer send/receive these evals
…tocol/aztec-packages into si/eccvm-translator-zk-sumcheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned on ZK Sumcheck in ECCVM and Translator Flavors.
Benching
ClientIvcwith ZK sumcheck turned on in ECCVM and Translator:*Using non-optimized ZK Sumcheck