Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensuring translator range constraint polynomials are zeroes outside of minicircuit #9251

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+723 −4
Open

fix: Ensuring translator range constraint polynomials are zeroes outside of minicircuit #9251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58b04ce
Added relations
Rumata888 Oct 15, 2024
efcaf6b
Added correctness tests
Rumata888 Oct 16, 2024
e8dc013
Consistency tests
Rumata888 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions barretenberg/cpp/src/barretenberg/relations/translator_vm/translator_extra_relations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
#include "barretenberg/relations/translator_vm/translator_extra_relations.hpp"
#include "barretenberg/relations/translator_vm/translator_extra_relations_impl.hpp"
#include "barretenberg/translator_vm/translator_flavor.hpp"
namespace bb {
template class TranslatorOpcodeConstraintRelationImpl<fr>;
template class TranslatorAccumulatorTransferRelationImpl<fr>;
template class TranslatorZeroConstraintsRelationImpl<fr>;

DEFINE_SUMCHECK_RELATION_CLASS(TranslatorOpcodeConstraintRelationImpl, TranslatorFlavor);
DEFINE_SUMCHECK_RELATION_CLASS(TranslatorAccumulatorTransferRelationImpl, TranslatorFlavor);
DEFINE_SUMCHECK_RELATION_CLASS(TranslatorZeroConstraintsRelationImpl, TranslatorFlavor);
} // namespace bb
177 changes: 177 additions & 0 deletions barretenberg/cpp/src/barretenberg/relations/translator_vm/translator_extra_relations.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,186 @@ polynomials,
const FF& scaling_factor);
};

template <typename FF_> class TranslatorZeroConstraintsRelationImpl {
public:
using FF = FF_;

// 1 + polynomial degree of this relation
static constexpr size_t RELATION_LENGTH = 3; // degree((some lagrange)(A)) = 2
static constexpr std::array<size_t, 64> SUBRELATION_PARTIAL_LENGTHS{
3, // p_x_low_limbs_range_constraint_0 is zero outside of the minicircuit
3, // p_x_low_limbs_range_constraint_1 is zero outside of the minicircuit
3, // p_x_low_limbs_range_constraint_2 is zero outside of the minicircuit
3, // p_x_low_limbs_range_constraint_3 is zero outside of the minicircuit
3, // p_x_low_limbs_range_constraint_4 is zero outside of the minicircuit
3, // p_x_high_limbs_range_constraint_0 is zero outside of the minicircuit
3, // p_x_high_limbs_range_constraint_1 is zero outside of the minicircuit
3, // p_x_high_limbs_range_constraint_2 is zero outside of the minicircuit
3, // p_x_high_limbs_range_constraint_3 is zero outside of the minicircuit
3, // p_x_high_limbs_range_constraint_4 is zero outside of the minicircuit
3, // p_y_low_limbs_range_constraint_0 is zero outside of the minicircuit
3, // p_y_low_limbs_range_constraint_1 is zero outside of the minicircuit
3, // p_y_low_limbs_range_constraint_2 is zero outside of the minicircuit
3, // p_y_low_limbs_range_constraint_3 is zero outside of the minicircuit
3, // p_y_low_limbs_range_constraint_4 is zero outside of the minicircuit
3, // p_y_high_limbs_range_constraint_0 is zero outside of the minicircuit
3, // p_y_high_limbs_range_constraint_1 is zero outside of the minicircuit
3, // p_y_high_limbs_range_constraint_2 is zero outside of the minicircuit
3, // p_y_high_limbs_range_constraint_3 is zero outside of the minicircuit
3, // p_y_high_limbs_range_constraint_4 is zero outside of the minicircuit
3, // z_low_limbs_range_constraint_0 is zero outside of the minicircuit
3, // z_low_limbs_range_constraint_1 is zero outside of the minicircuit
3, // z_low_limbs_range_constraint_2 is zero outside of the minicircuit
3, // z_low_limbs_range_constraint_3 is zero outside of the minicircuit
3, // z_low_limbs_range_constraint_4 is zero outside of the minicircuit
3, // z_high_limbs_range_constraint_0 is zero outside of the minicircuit
3, // z_high_limbs_range_constraint_1 is zero outside of the minicircuit
3, // z_high_limbs_range_constraint_2 is zero outside of the minicircuit
3, // z_high_limbs_range_constraint_3 is zero outside of the minicircuit
3, // z_high_limbs_range_constraint_4 is zero outside of the minicircuit
3, // accumulator_low_limbs_range_constraint_0 is zero outside of the minicircuit
3, // accumulator_low_limbs_range_constraint_1 is zero outside of the minicircuit
3, // accumulator_low_limbs_range_constraint_2 is zero outside of the minicircuit
3, // accumulator_low_limbs_range_constraint_3 is zero outside of the minicircuit
3, // accumulator_low_limbs_range_constraint_4 is zero outside of the minicircuit
3, // accumulator_high_limbs_range_constraint_0 is zero outside of the minicircuit
3, // accumulator_high_limbs_range_constraint_1 is zero outside of the minicircuit
3, // accumulator_high_limbs_range_constraint_2 is zero outside of the minicircuit
3, // accumulator_high_limbs_range_constraint_3 is zero outside of the minicircuit
3, // accumulator_high_limbs_range_constraint_4 is zero outside of the minicircuit
3, // quotient_low_limbs_range_constraint_0 is zero outside of the minicircuit
3, // quotient_low_limbs_range_constraint_1 is zero outside of the minicircuit
3, // quotient_low_limbs_range_constraint_2 is zero outside of the minicircuit
3, // quotient_low_limbs_range_constraint_3 is zero outside of the minicircuit
3, // quotient_low_limbs_range_constraint_4 is zero outside of the minicircuit
3, // quotient_high_limbs_range_constraint_0 is zero outside of the minicircuit
3, // quotient_high_limbs_range_constraint_1 is zero outside of the minicircuit
3, // quotient_high_limbs_range_constraint_2 is zero outside of the minicircuit
3, // quotient_high_limbs_range_constraint_3 is zero outside of the minicircuit
3, // quotient_high_limbs_range_constraint_4 is zero outside of the minicircuit
3, // relation_wide_limbs_range_constraint_0 is zero outside of the minicircuit
3, // relation_wide_limbs_range_constraint_1 is zero outside of the minicircuit
3, // relation_wide_limbs_range_constraint_2 is zero outside of the minicircuit
3, // relation_wide_limbs_range_constraint_3 is zero outside of the minicircuit
3, // p_x_low_limbs_range_constraint_tail is zero outside of the minicircuit
3, // p_x_high_limbs_range_constraint_tail is zero outside of the minicircuit
3, // p_y_low_limbs_range_constraint_tail is zero outside of the minicircuit
3, // p_y_high_limbs_range_constraint_tail is zero outside of the minicircuit
3, // z_low_limbs_range_constraint_tail is zero outside of the minicircuit
3, // z_high_limbs_range_constraint_tail is zero outside of the minicircuit
3, // accumulator_low_limbs_range_constraint_tail is zero outside of the minicircuit
3, // accumulator_high_limbs_range_constraint_tail is zero outside of the minicircuit
3, // quotient_low_limbs_range_constraint_tail is zero outside of the minicircuit
3, // quotient_high_limbs_range_constraint_tail is zero outside of the minicircuit

};
/**
* @brief For ZK-Flavors: Upper bound on the degrees of subrelations considered as polynomials only in witness
polynomials,
* i.e. all selectors and public polynomials are treated as constants. The subrelation witness degree does not
* exceed the subrelation partial degree given by SUBRELATION_PARTIAL_LENGTH - 1.
*/
static constexpr std::array<size_t, 64> SUBRELATION_WITNESS_DEGREES{
2, // p_x_low_limbs_range_constraint_0 is zero outside of the minicircuit
2, // p_x_low_limbs_range_constraint_1 is zero outside of the minicircuit
2, // p_x_low_limbs_range_constraint_2 is zero outside of the minicircuit
2, // p_x_low_limbs_range_constraint_3 is zero outside of the minicircuit
2, // p_x_low_limbs_range_constraint_4 is zero outside of the minicircuit
2, // p_x_high_limbs_range_constraint_0 is zero outside of the minicircuit
2, // p_x_high_limbs_range_constraint_1 is zero outside of the minicircuit
2, // p_x_high_limbs_range_constraint_2 is zero outside of the minicircuit
2, // p_x_high_limbs_range_constraint_3 is zero outside of the minicircuit
2, // p_x_high_limbs_range_constraint_4 is zero outside of the minicircuit
2, // p_y_low_limbs_range_constraint_0 is zero outside of the minicircuit
2, // p_y_low_limbs_range_constraint_1 is zero outside of the minicircuit
2, // p_y_low_limbs_range_constraint_2 is zero outside of the minicircuit
2, // p_y_low_limbs_range_constraint_3 is zero outside of the minicircuit
2, // p_y_low_limbs_range_constraint_4 is zero outside of the minicircuit
2, // p_y_high_limbs_range_constraint_0 is zero outside of the minicircuit
2, // p_y_high_limbs_range_constraint_1 is zero outside of the minicircuit
2, // p_y_high_limbs_range_constraint_2 is zero outside of the minicircuit
2, // p_y_high_limbs_range_constraint_3 is zero outside of the minicircuit
2, // p_y_high_limbs_range_constraint_4 is zero outside of the minicircuit
2, // z_low_limbs_range_constraint_0 is zero outside of the minicircuit
2, // z_low_limbs_range_constraint_1 is zero outside of the minicircuit
2, // z_low_limbs_range_constraint_2 is zero outside of the minicircuit
2, // z_low_limbs_range_constraint_3 is zero outside of the minicircuit
2, // z_low_limbs_range_constraint_4 is zero outside of the minicircuit
2, // z_high_limbs_range_constraint_0 is zero outside of the minicircuit
2, // z_high_limbs_range_constraint_1 is zero outside of the minicircuit
2, // z_high_limbs_range_constraint_2 is zero outside of the minicircuit
2, // z_high_limbs_range_constraint_3 is zero outside of the minicircuit
2, // z_high_limbs_range_constraint_4 is zero outside of the minicircuit
2, // accumulator_low_limbs_range_constraint_0 is zero outside of the minicircuit
2, // accumulator_low_limbs_range_constraint_1 is zero outside of the minicircuit
2, // accumulator_low_limbs_range_constraint_2 is zero outside of the minicircuit
2, // accumulator_low_limbs_range_constraint_3 is zero outside of the minicircuit
2, // accumulator_low_limbs_range_constraint_4 is zero outside of the minicircuit
2, // accumulator_high_limbs_range_constraint_0 is zero outside of the minicircuit
2, // accumulator_high_limbs_range_constraint_1 is zero outside of the minicircuit
2, // accumulator_high_limbs_range_constraint_2 is zero outside of the minicircuit
2, // accumulator_high_limbs_range_constraint_3 is zero outside of the minicircuit
2, // accumulator_high_limbs_range_constraint_4 is zero outside of the minicircuit
2, // quotient_low_limbs_range_constraint_0 is zero outside of the minicircuit
2, // quotient_low_limbs_range_constraint_1 is zero outside of the minicircuit
2, // quotient_low_limbs_range_constraint_2 is zero outside of the minicircuit
2, // quotient_low_limbs_range_constraint_3 is zero outside of the minicircuit
2, // quotient_low_limbs_range_constraint_4 is zero outside of the minicircuit
2, // quotient_high_limbs_range_constraint_0 is zero outside of the minicircuit
2, // quotient_high_limbs_range_constraint_1 is zero outside of the minicircuit
2, // quotient_high_limbs_range_constraint_2 is zero outside of the minicircuit
2, // quotient_high_limbs_range_constraint_3 is zero outside of the minicircuit
2, // quotient_high_limbs_range_constraint_4 is zero outside of the minicircuit
2, // relation_wide_limbs_range_constraint_0 is zero outside of the minicircuit
2, // relation_wide_limbs_range_constraint_1 is zero outside of the minicircuit
2, // relation_wide_limbs_range_constraint_2 is zero outside of the minicircuit
2, // relation_wide_limbs_range_constraint_3 is zero outside of the minicircuit
2, // p_x_low_limbs_range_constraint_tail is zero outside of the minicircuit
2, // p_x_high_limbs_range_constraint_tail is zero outside of the minicircuit
2, // p_y_low_limbs_range_constraint_tail is zero outside of the minicircuit
2, // p_y_high_limbs_range_constraint_tail is zero outside of the minicircuit
2, // z_low_limbs_range_constraint_tail is zero outside of the minicircuit
2, // z_high_limbs_range_constraint_tail is zero outside of the minicircuit
2, // accumulator_low_limbs_range_constraint_tail is zero outside of the minicircuit
2, // accumulator_high_limbs_range_constraint_tail is zero outside of the minicircuit
2, // quotient_low_limbs_range_constraint_tail is zero outside of the minicircuit
2, // quotient_high_limbs_range_constraint_tail is zero outside of the minicircuit

};
/**
* @brief Returns true if the contribution from all subrelations for the provided inputs is identically zero
*
* @details This has a negligible chance of failing in sumcheck (not in the first round) because effectively
* transfrom original coefficients into a random linear combination. But checking each individually is noticeably
* slower.
*
*/
template <typename AllEntities> inline static bool skip(const AllEntities& in)
{
static constexpr auto minus_one = -FF(1);
return (in.lagrange_even_in_minicircuit + in.lagrange_second_to_last_in_minicircuit + minus_one).is_zero();
}
/**
* @brief Relation enforcing all the range-constraint polynomials to be zero after the minicircuit
* @details This relation ensures that while we are out of the minicircuit the range constraint polynomials are zero
*
* @param evals transformed to `evals + C(in(X)...)*scaling_factor`
* @param in an std::array containing the fully extended Univariate edges.
* @param parameters contains beta, gamma, and public_input_delta, ....
* @param scaling_factor optional term to scale the evaluation before adding to evals.
*/
template <typename ContainerOverSubrelations, typename AllEntities, typename Parameters>
static void accumulate(ContainerOverSubrelations& accumulators,
const AllEntities& in,
const Parameters& params,
const FF& scaling_factor);
};

template <typename FF> using TranslatorOpcodeConstraintRelation = Relation<TranslatorOpcodeConstraintRelationImpl<FF>>;

template <typename FF>
using TranslatorAccumulatorTransferRelation = Relation<TranslatorAccumulatorTransferRelationImpl<FF>>;

template <typename FF> using TranslatorZeroConstraintsRelation = Relation<TranslatorZeroConstraintsRelationImpl<FF>>;

} // namespace bb
Loading
Loading