Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify private calldata to use public keys #9276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sklppy88
Copy link
Contributor

@sklppy88 sklppy88 commented Oct 18, 2024

In this PR we are modifying private calldata to use public keys instead of only the public keys hash. This is in preparation for the new address changes in which we private calldata is needed to validate a contract address in the kernels in validate_contract_address (validate_contract_address uses information from the private calldata struct), and we need to constrain that a contract address can be recomputed using its entire set of public keys with AztecAddress::compute_from_private_function.

Copy link
Contributor Author

sklppy88 commented Oct 18, 2024

@sklppy88 sklppy88 changed the title init feat: modify private calldata to use public keys Oct 18, 2024
@sklppy88 sklppy88 marked this pull request as ready for review October 18, 2024 10:00
@sklppy88 sklppy88 added the e2e-all CI: Enables this CI job. label Oct 18, 2024
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Changes to circuit sizes

Generated at commit: 08159b8780f0504033150a9267446760a1d76b19, compared to commit: ed933eefc2aab4b616dca94fee9a02837aec7fb9

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init +57 ❌ +0.23% +429 ❌ +1.33%
private_kernel_inner +57 ❌ +0.13% +429 ❌ +0.81%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init 25,060 (+57) +0.23% 32,712 (+429) +1.33%
private_kernel_inner 44,160 (+57) +0.13% 53,306 (+429) +0.81%

@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-private-calldata-to-use-public-keys-instead-of-public-keys-hash branch from 5b8d888 to dea191e Compare October 18, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-all CI: Enables this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant