fix: witness generation and PIL formatting for empty_vm #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The empty_vm test was failing due to two issues: 1. Incorrect witness generation for operation_id 2. Formatting issues in the PIL output causing assertion failures Description ----------- - Modified witness generation to use constant value 2 for main._operation_id - Fixed PIL formatting in linker to match expected output format - Proper formating in polynomial declarations - Aligned witness generation with the expected values for registers - Introduced build automation testing the fix -------------- fetch this PR branch and from the root directory run ``` make setup ``` and then ``` cargo test test::compile_empty_vm ``` to see all available repo commands during development, run ``` make help ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The empty_vm test was failing due to two issues:
PILoutput causing assertion failuresDescription
Testing the fix
fetch this PR branch and from the root directory run
and then
cargo test test::compile_empty_vmTo see all available repo commands during development, run
make help