Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate slashes in path in BlobContainerClient #39

Closed
wants to merge 2 commits into from
Closed

Fix duplicate slashes in path in BlobContainerClient #39

wants to merge 2 commits into from

Conversation

joester89
Copy link

@joester89
Update BlobContainerClient.php
6749cde 
Fix bug where duplicate slashes are added.
@joester89 joester89 changed the title Update BlobContainerClient.php Fix duplicate slashes in path in BlobContainerClient Oct 23, 2024
@brecht-vermeersch
Copy link
Member

Hi! Thanks for the PR. Can you add a test for this?

@brecht-vermeersch brecht-vermeersch self-assigned this Oct 23, 2024
pimjansen
pimjansen approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@pimjansen pimjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pimjansen
Copy link
Contributor

Please check since code style fails

@brecht-vermeersch
Copy link
Member

brecht-vermeersch commented Oct 31, 2024 •
edited
Loading

#39

Will be fixed in this PR. Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimjansen pimjansen pimjansen approved these changes

Assignees

@brecht-vermeersch brecht-vermeersch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joester89 @brecht-vermeersch @pimjansen