Using Remapper in Android #204
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SameerK-MSFT
requested review from
pmaytak,
trwalke,
bgavrilMS,
gladjohn and
neha-bhargava
bgavrilMS
reviewed
Sep 6, 2022
| @@ -28,16 +30,34 @@ class EnrollmentNotificationReceiver : Java.Lang.Object, IMAMNotificationReceive | |||
| /// </returns> | |||
| public bool OnReceive(IMAMNotification notification) | |||
| { | |||
| Debug.WriteLine("***Begin EnrollmentNotificationReceiver -> OnReceive"); | |||
There was a problem hiding this comment.
maybe log the notification type from the start.
bgavrilMS
reviewed
Sep 6, 2022
| IMAMComplianceManager mgr = MAMComponents.Get<IMAMComplianceManager>(); | ||
| mgr.RemediateCompliance(exProtection.Upn, exProtection.AccountUserId, exProtection.TenantId, exProtection.AuthorityUrl, false); | ||
| }).ConfigureAwait(false); | ||
| await Task.Run(() => |
There was a problem hiding this comment.
Please add a comment explaining why you do this on a background thread.
bgavrilMS
approved these changes
Sep 6, 2022
pmaytak
reviewed
Sep 6, 2022
| @@ -28,16 +30,34 @@ class EnrollmentNotificationReceiver : Java.Lang.Object, IMAMNotificationReceive | |||
| /// </returns> | |||
| public bool OnReceive(IMAMNotification notification) | |||
| { | |||
| Debug.WriteLine("***Begin EnrollmentNotificationReceiver -> OnReceive"); | |||
There was a problem hiding this comment.
Why is the remapper needed? Is it only for CITI scenario? If so, since this is a public sample, can we put these changes into a dev app to not clutter the sample? Otherwise, I would clarify what the remapper does.
Similarly to the above, these log messages make it less clear on what's going on with the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.