Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm rules engine and Playwright tests #100

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

smurawski
Copy link
Contributor

Purpose

Basic end to end playwright tests for the store-admin were added.
A wasm rules engine was added to the product service. By default it is disabled.
The product service was refactored for extensibility and maintainability.
The product service has additional unit tests and integration tests.
Error conditions in the product service (get by id and the AI proxy) are handled and return appropriate HTTP errors rather than crashing the service.

Additional documentation on using/extending the wasm rules engine will be in a future PR.

  • ...

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@smurawski smurawski force-pushed the wasm_rules_engine branch 4 times, most recently from 1a60c58 to 60b4f5e Compare February 2, 2024 19:43
@smurawski smurawski force-pushed the wasm_rules_engine branch 4 times, most recently from dff765a to c12029c Compare February 7, 2024 19:43
@smurawski smurawski changed the title Wasm rules engine, Playwright tests, and AI Proxy Routes Wasm rules engine and Playwright tests Feb 7, 2024
@pauldotyu pauldotyu self-requested a review February 8, 2024 17:11
Copy link
Contributor

@pauldotyu pauldotyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome contribution, @smurawski!

The Wasm rules engine is slick and the e2e Playwright testing is long overdue. Many thanks!!

@pauldotyu pauldotyu merged commit a6a3bf6 into Azure-Samples:main Feb 8, 2024
1 check passed
@smurawski smurawski deleted the wasm_rules_engine branch February 9, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants