Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade sk,others to latest version #86

Merged
merged 4 commits into from
Jan 16, 2024
Merged

upgrade sk,others to latest version #86

merged 4 commits into from
Jan 16, 2024

Conversation

mosabami
Copy link
Collaborator

Purpose

Upgrade SK and other packages in the ai-service to latest version and made code modifications required to make it work

Does this introduce a breaking change?

[ ] Yes
[X ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ X] Other... Please describe: package upgrade

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@pauldotyu pauldotyu self-requested a review January 9, 2024 00:06
@pauldotyu
Copy link
Contributor

Overall LTGM.
I did need to make a small change to init AzureChatCompletion for AAD auth. Also noticed the ai-service needs more memory now so bumped its limit to 85MB in ai-service.yaml files. This also requires changes in our docs so will merge this change after https://github.com/MicrosoftDocs/azure-docs-pr/pull/262737 has been merged.

@pauldotyu pauldotyu merged commit eefdcdf into main Jan 16, 2024
4 checks passed
@pauldotyu pauldotyu deleted the ai-serivice-upgrade branch January 16, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants