Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bug-10777| LLM Model Responds in Spanish #1544

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: Bug-10777| LLM Model Responds in Spanish #1544

wants to merge 2 commits into from

Conversation

Roopan-Microsoft
Copy link
Contributor

@Roopan-Microsoft Roopan-Microsoft commented Nov 28, 2024 •
edited
Loading

Purpose

  • Fixed: LLM Model Responds in Spanish when we ask questions in english
  • Now it will keep default language as English and reply in the language what user speaks.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
  • Deploy
  • Ask questions in different languages
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • Ask questions in different languages

Other Information

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/orchestrator
   open_ai_functions.py591574%116–118, 121, 124–125, 128, 133–135, 137–139, 142, 147
TOTAL310991570% 

Tests Skipped Failures Errors Time
301 0 💤 0 ❌ 0 🔥 49.847s ⏱️

marktayl1
marktayl1 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@marktayl1 marktayl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve changes to prompting. All prompting seems only related to language choice and does not appear to impact the scenario outside of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marktayl1 marktayl1 marktayl1 approved these changes

@Avijit-Microsoft Avijit-Microsoft Awaiting requested review from Avijit-Microsoft Avijit-Microsoft is a code owner

@Prajwal-Microsoft Prajwal-Microsoft Awaiting requested review from Prajwal-Microsoft Prajwal-Microsoft is a code owner

@Fr4nc3 Fr4nc3 Awaiting requested review from Fr4nc3 Fr4nc3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Roopan-Microsoft @marktayl1