-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable deployment to Azure AppService #63
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-sanderv
pushed a commit
to t-sanderv/communication-services-web-calling-tutorial
that referenced
this pull request
Aug 24, 2022
…/webpack-dev-update update webpack dev server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Test the functionality here
This pull request fixes #37 and introduces a separate server application into the package, and ARM templates for deployment to Azure.
For a project with a similar structure, check out Azure-Samples/communication-services-web-chat-hero.
Submission containing materials of a third party: Azure-Samples/communication-services-web-chat-hero
Server Application
An ExpressJS Node server was added in the Server folder. Previously, only a dev server was available through webpack which could provision a user and a token. This dev server should not be used when deploying this as a sample application. That is why a new ExpressJS server application was added. In dev mode, the webpack dev server proxies any request to
/tokens/provisionUser
to the local 8080 port where the Server application is listening.A top-level
package.json
has been added to facilitate easy installing of packages, starting dev environment, building, and packaging the Client and Server application.ARM Templates
To facilitate deployment to Azure, two Bicep files have been added. These files can be transpiled to JSON ARM templates using
az bicep build --file <filename>
.Two bicep templates have been added: One to create all resources necessary for deployment (
azuredeploy.bicep
), and one to create all resources except an Azure Communications Service resource (azuredeploy_existingresource.bicep
).One can test these ARM templates in Azure by clicking here
Does this introduce a breaking change?
Breaking because the
Project
directory was renamed toClient
.Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
To test the deployment
deploy/azuredeploy.json
What to Check
Verify that the following are valid
Other Information