Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deployment to Azure AppService #63

Closed
wants to merge 63 commits into from

Conversation

t-sanderv
Copy link

@t-sanderv t-sanderv commented Aug 2, 2022

Purpose

Test the functionality here

This pull request fixes #37 and introduces a separate server application into the package, and ARM templates for deployment to Azure.
For a project with a similar structure, check out Azure-Samples/communication-services-web-chat-hero.

Submission containing materials of a third party: Azure-Samples/communication-services-web-chat-hero

Server Application

An ExpressJS Node server was added in the Server folder. Previously, only a dev server was available through webpack which could provision a user and a token. This dev server should not be used when deploying this as a sample application. That is why a new ExpressJS server application was added. In dev mode, the webpack dev server proxies any request to /tokens/provisionUser to the local 8080 port where the Server application is listening.

A top-level package.json has been added to facilitate easy installing of packages, starting dev environment, building, and packaging the Client and Server application.

ARM Templates

To facilitate deployment to Azure, two Bicep files have been added. These files can be transpiled to JSON ARM templates using az bicep build --file <filename>.
Two bicep templates have been added: One to create all resources necessary for deployment (azuredeploy.bicep), and one to create all resources except an Azure Communications Service resource (azuredeploy_existingresource.bicep).

One can test these ARM templates in Azure by clicking here

Does this introduce a breaking change?

[X] Yes
[] No

Breaking because the Project directory was renamed to Client.

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone https://github.com/t-sanderv/communication-services-web-calling-tutorial.git
cd communication-services-web-calling-tutorial
git checkout main
npm run setup
npm run start
  • Test the code

To test the deployment

  1. Copy the contents of deploy/azuredeploy.json

What to Check

Verify that the following are valid

  • ...

Other Information

t-sanderv pushed a commit to t-sanderv/communication-services-web-calling-tutorial that referenced this pull request Aug 24, 2022
…/webpack-dev-update

update webpack dev server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Communication Service - unable to run the quickstart app in Azure App Service
3 participants