-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trustworthy ai demo #280
Draft
changliu2
wants to merge
13
commits into
ignite2024
Choose a base branch
from
trustworthy-ai-demo
base: ignite2024
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Trustworthy ai demo #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hes; added retry logic up to 3 times and updated resaercher model to 4o
…~2m/article), and debugging msg to clarify use case of tracing
changliu2
commented
Nov 20, 2024
removed unused line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of improvements:
4o agents:
Large-scale tests:
For robustness test, I ran the agent app 100 times over 11 data points. It stopped short at 46 runs due to az login credentials on expiring on codespace in this 3+ hour job, so a total 3x11x46~=1500 agent calls), there are 2 errors triggered out of 1500 calls, or a 0.001% error rate. Both errors were json object returned by llm not properly escaped. It looks like this: Agents failed to produce an article. Examine trace for details. Top layer error message: OpenAI API hits exception: JSONDecodeError: Expecting property name enclosed in double quotes: line 3 column 522 (char 556). See run log attached for details (search for "Agents failed").
For latency test, this 3+ hour job averaged about half a min per data point in codespace (faster than my 1 min estimate on my laptop). Estimates were based on the timestamp when the code first errored out. See run log attached for details.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information