-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skillable Lab setup Python script #287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricvidal
force-pushed
the
lab-setup-script
branch
from
December 7, 2024 05:59
21472b4
to
7c2b636
Compare
cedricvidal
force-pushed
the
lab-setup-script
branch
from
December 8, 2024 11:08
7c2b636
to
36f6fde
Compare
Reverse Reverse
cedricvidal
force-pushed
the
lab-setup-script
branch
from
December 8, 2024 11:24
36f6fde
to
84731d5
Compare
This looks good to me! I will update the lab manual though so that they start at workshop notebook 1 after running the script |
marlenezw
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Converts the
LAB-SETUP.ipynb
notebook into a Python script.Important
Keeps the notebook around as fallback in case the script doesn't work as expected.
Here's a recording:
Also, added after the video was recorded:
--force
executing from the beginning as well as pass a--step
param to resume from an arbitrary stepUpdated lab manual
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test