Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skillable Lab setup Python script #287

Merged
merged 33 commits into from
Dec 9, 2024

Conversation

cedricvidal
Copy link
Contributor

@cedricvidal cedricvidal commented Dec 7, 2024

Purpose

Converts the LAB-SETUP.ipynb notebook into a Python script.

Important

Keeps the notebook around as fallback in case the script doesn't work as expected.

Here's a recording:

Video

Also, added after the video was recorded:

  • the script stores progress in a temp file. If something goes wrong, you can re-execute the script, it will resume from where it left.
  • you can --force executing from the beginning as well as pass a --step param to resume from an arbitrary step

Updated lab manual
Screenshot 2024-12-07 at 4 59 48 PM

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

./docs/workshop/lab_setup.py --username SKILLABLE_USERNAME \
    --password SKILLABLE_PASSWORD \
    --azure-env-name SKILLABLE_AZD_ENV_NAME \
    --subscription SKILLABLE_SUBSCRIPTION

@cedricvidal cedricvidal changed the base branch from main to ignite2024 December 7, 2024 04:48
@cedricvidal cedricvidal changed the base branch from ignite2024 to main December 8, 2024 11:25
@marlenezw marlenezw self-requested a review December 9, 2024 16:17
@marlenezw
Copy link
Contributor

This looks good to me! I will update the lab manual though so that they start at workshop notebook 1 after running the script

Copy link
Contributor

@marlenezw marlenezw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marlenezw marlenezw merged commit 70936cb into Azure-Samples:main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants