Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uvloop issue #209

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Fix uvloop issue #209

merged 3 commits into from
Oct 25, 2024

Conversation

pamelafox
Copy link
Collaborator

Purpose

Fixes #160 and #205 by only bringing in uvicorn requirements that are necessary and including windows marker for uvloop.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Install locally, run server
  • Wait for CI to finish on windows

@pamelafox pamelafox merged commit ac23284 into main Oct 25, 2024
3 checks passed
@pamelafox pamelafox deleted the uvloop branch October 25, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run the command pip install -r requirements-dev.txt fail in Local
1 participant