Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logic to add availability zones in parameters files for the networking platform resources depending on the selected region #104

Closed
wants to merge 5 commits into from

Conversation

sebassem
Copy link
Contributor

@sebassem sebassem commented Mar 6, 2024

Pull Request

Issue

Issue #103 and #102

Description

Adding a new private function to determine the availability zones for the selected regions and edit the parameters files of the relevant networking modules to include them by default.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.

Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sebassem, this works perfect from my initial testing! What are your thoughts on potentially adding a unit test for this function? I can't see us modifying this function too much long term, but just curious if you have any thoughts.

@sebassem
Copy link
Contributor Author

Hey @sebassem, this works perfect from my initial testing! What are your thoughts on potentially adding a unit test for this function? I can't see us modifying this function long term, but just curious if you have any thoughts.

sure thing , I can give it a try and see if its easy to implement.

@sebassem
Copy link
Contributor Author

@oZakari I added a unit test for the function, please let me know if its ok

@jaredfholgate
Copy link
Member

Hi @sebassem. I just saw this pull request is in progress. I have been working on a major refactor and have most likely broken your work, but given it looks like this is Bicep specific, you should be able to update the code to work with the new code base. Let me know if you need help though and apologies for pipping you to the post with my changes.

@sebassem
Copy link
Contributor Author

Hi @sebassem. I just saw this pull request is in progress. I have been working on a major refactor and have most likely broken your work, but given it looks like this is Bicep specific, you should be able to update the code to work with the new code base. Let me know if you need help though and apologies for pipping you to the post with my changes.

No worries @jaredfholgate I just created a new branch of the new changes and submitted a PR

@sebassem sebassem closed this Mar 17, 2024
@sebassem sebassem deleted the availability_zones_params branch August 12, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants