feat: add sql failover group customer managed policy recommendation

[jdmsoss]

Overview/Summary

New Azure SQL recommendation based on following official documentation best practice: Setting your failover policy to customer managed is highly recommended, as it keeps you in control of when to initiate a failover and restore business continuity. You can initiate a failover when you notice an unexpected outage impacting one or more databases in the failover group.

As part of this pull request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Checked for duplicate Pull Requests
• Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Ensured PR tests are passing
• Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
• Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

[ejhenry]

Thanks @jdmsoss, please also include a kql file for the new recommendation in this PR.

[jdmsoss]

Thanks @jdmsoss, please also include a kql file for the new recommendation in this PR.

Unfortunately, it seems that this information is not exposed in ARG. Therefore, you will have to check it manually.

[ejhenry]

Thanks @jdmsoss, please also include a kql file for the new recommendation in this PR.

Unfortunately, it seems that this information is not exposed in ARG. Therefore, you will have to check it manually.

For this scenario we will want a kql file indicating the recommendation cannot be validated with ARG. This is needed by the APRL scripts. Details are here: https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/contributing/create-content/create-arg-queries/

[jdmsoss]

Thanks @jdmsoss, please also include a kql file for the new recommendation in this PR.

Unfortunately, it seems that this information is not exposed in ARG. Therefore, you will have to check it manually.

For this scenario we will want a kql file indicating the recommendation cannot be validated with ARG. This is needed by the APRL scripts. Details are here: https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/contributing/create-content/create-arg-queries/

Indeed, that makes sense. Sorry for forgetting that. I'll fix it as soon as I have a slot for APRL contribution on my side.

[jdmsoss]

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

Please allow me some time to apply this change

[oZakari]

LGTM

[ejhenry]

@jdmsoss can you update your PR to address the failed checks? Let me know if you have any questions about the checks or needed changes.

[jdmsoss]

@jdmsoss can you update your PR to address the failed checks? Let me know if you have any questions about the checks or needed changes.

@ejhenry it should be ok now!

[jdmsoss]

It seems yaml_file_check failed because:

Error validating data './azure-resources/Sql/servers/recommendations.yaml' with schema '.github/scripts/schemas/aprl-schema.yaml' 7.recommendationControl: 'Disaster Recovery' not in ('HighAvailability', 'BusinessContinuity', 'DisasterRecovery', 'Scalability', 'MonitoringAndAlerting', 'ServiceUpgradeAndRetirement', 'OtherBestPractices', 'Personalized', 'Governance', 'Security')

But when I look at the other recommendations in this file, none of them are properly formatted according to this rule.

I don't see how to fix the problem which for me goes beyond my PR (I can change recommendationControl value of my new reco but what about all other recommendations using the same synthaxis regarding this rule?).

[oZakari]

Hey @jdmsoss, the value needs to be DisasterRecovery and not 'Disaster Recovery'. Your branch is out of date which is why the other files still have spaces.

If you join the Azure org with your account, I would be able to sync your branch and also update the value as a future reference.

[jdmsoss]

Hey @jdmsoss, the value needs to be DisasterRecovery and not 'Disaster Recovery'. Your branch is out of date which is why the other files still have spaces.

If you join the Azure org with your account, I would be able to sync your branch and also update the value as a future reference.

Hi @oZakari I see. I submitted a new commit to fix the whole file to align with this change. I hope this time it's the right one!

[oZakari]

@jdmsoss There appear to be some merge conflicts that will need to be resolved prior to us being able to re-run the tests. Ping me if you need help though.

[jdmsoss]

@oZakari Decidedly ... Ok I take note of these new conflicts. Otherwise wouldn't it be easier for me to reopen a PR based on the current main repo version to submit this conflict-free PR?
If so, I'll reference the new PR in this PR and then close it, because we're wasting more time than this new recommendation will save us 😅