Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Update VM APRL per Disk PMs #402

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Update VM APRL per Disk PMs #402

merged 5 commits into from
Apr 4, 2024

Conversation

pinyuko
Copy link
Contributor

@pinyuko pinyuko commented Mar 26, 2024

Overview/Summary

Disk PM updates

Related Issues/Work Items

Replace this with a list of related GitHub Issues and/or ADO Work Items (Internal Only)

  • To associate a GitHub Issue, use a key word preceded with the GitHub issue number.
  • To associate an ADO Work Item, use the key word AB# succeeded with the ADO Work Item ID.

This PR fixes/adds/changes/removes

  1. VM-6 remove "application" since it's possible for customer to host application on OS disks. Confirmed with Raman Kumar and Rodrigo Reis Santos to remove the application part.
  2. Minor update the resource links

Breaking Changes

N/A

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries and/or scripts
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejhenry ejhenry added Area: Service Guidance Improvements or additions to documentation Needs: Attention from aprl-admins 👋 Needs attention from aprl-admins GitHub team. labels Mar 27, 2024
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much @pinyuko, LGTM

@oZakari
Copy link
Contributor

oZakari commented Mar 27, 2024

@pinyuko, this PR is still in draft mode, so feel free to set to ready for review if applicable and we will merge.

@oZakari oZakari added Needs: Author Feedback and removed Needs: Attention from aprl-admins 👋 Needs attention from aprl-admins GitHub team. labels Apr 3, 2024
@pinyuko pinyuko marked this pull request as ready for review April 4, 2024 16:30
@pinyuko pinyuko requested a review from a team as a code owner April 4, 2024 16:30
@pinyuko
Copy link
Contributor Author

pinyuko commented Apr 4, 2024

Ready to be merged. Thanks!

@oZakari oZakari merged commit b3b2d9c into Azure:main Apr 4, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Service Guidance Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants