Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illumio Sentinel Solution #10392

Merged
merged 57 commits into from
May 16, 2024
Merged

Conversation

ashwinvenkatesha
Copy link
Contributor

Change(s):

  • Added a data connector that uses logs ingestion API to ingest data into custom tables.
  • Added an ARM template to create required azure resources and function app.
  • Added readme
  • Added sample data
  • Added workbook and its images (light and dark theme)

Reason for Change(s):

  • This is a new integration with Illumio using AWS S3/Azure

Version Updated:

  • This is the first version

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

@ashwinvenkatesha ashwinvenkatesha requested review from a team as code owners April 26, 2024 06:25
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Apr 26, 2024
@ashwinvenkatesha
Copy link
Contributor Author

ashwinvenkatesha commented Apr 26, 2024 via email

@ashwinvenkatesha
Copy link
Contributor Author

ashwinvenkatesha commented Apr 26, 2024 via email

@ashwinvenkatesha
Copy link
Contributor Author

I have a clarification,
https://github.com/Azure/Azure-Sentinel/tree/master/Solutions#guide-to-building-microsoft-sentinel-solutions
when do I need to work on Step 2, would it be after this pull request is approved? @v-prasadboke
and would it be part of this pull request?

@v-prasadboke
Copy link
Contributor

v-prasadboke commented Apr 29, 2024

Hello @ashwinvenkatesha,

  • Solution is missing with input file which is required to Package the Solution.
  • Solution is also missing with SolutionMetadata
  • Please add workbook metadata to below mentioned file

You can refer this Solution for Solution metadata and input file
https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Agari

And for workbook metadata, please add it to this file.
https://github.com/Azure/Azure-Sentinel/blob/master/Workbooks/WorkbooksMetadata.json

Can you provide me write access to this branch, So that I can commit required changes.
You can provide it by going to repo's setting and head to contributors access. You can send me an invitation from over there

@ashwinvenkatesha
Copy link
Contributor Author

ashwinvenkatesha commented Apr 30, 2024

Hello @ashwinvenkatesha,

  • Solution is missing with input file which is required to Package the Solution.
  • Solution is also missing with SolutionMetadata
  • Please add workbook metadata to below mentioned file

You can refer this Solution for Solution metadata and input file https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Agari

And for workbook metadata, please add it to this file. https://github.com/Azure/Azure-Sentinel/blob/master/Workbooks/WorkbooksMetadata.json

Can you provide me write access to this branch, So that I can commit required changes. You can provide it by going to repo's setting and head to contributors access. You can send me an invitation from over there

@v-prasadboke, thanks for checking the PR.
I have added workbook metadata and solution metadata as well.
Please check. Regarding solution package directory, I have created one locally.
Once you have verified this PR, do let me know I will upload the package files as well.
@v-prasadboke I have sent you an invite with write access. Thanks

@ashwinvenkatesha
Copy link
Contributor Author

@v-prasadboke
I have another question.
I want to add a workbook that talks to a custom endpoint. In this case, the custom endpoint is a function app http trigger.

Once the workbook loads, it invokes an api which is nothing but the http trigger function app.

This in turn calls a third party api from the function app, lets suppose, it returns a json content and workbook visualizes it. Note: I cannot directly call the third party app from workbook due to some limitations, hence the only option is this.

My question is , how do I address this new function app in my github solution that is being built.

@v-prasadboke
Copy link
Contributor

Hello @ashwinvenkatesha, Can we schedule a call regarding this.

I work in IST timezone and usually available after 10:00 AM. Tomorrow i.e 30-04-2024 is holiday for me.
We can Schedule it for 02-05-2024.

Please share your availability and timezone so we can plan for the same.

You can ping me on teams as well if needed. [email protected]

@ashwinvenkatesha
Copy link
Contributor Author

Hello @ashwinvenkatesha, Can we schedule a call regarding this.

I work in IST timezone and usually available after 10:00 AM. Tomorrow i.e 30-04-2024 is holiday for me. We can Schedule it for 02-05-2024.

Please share your availability and timezone so we can plan for the same.

You can ping me on teams as well if needed. [email protected]

Thanks a lot. Yes I am available on May 1st and May 2nd as well.
My timezone is PDT.

v-prasadboke
v-prasadboke previously approved these changes May 16, 2024
v-atulyadav
v-atulyadav previously approved these changes May 16, 2024
@v-prasadboke v-prasadboke dismissed stale reviews from v-atulyadav and themself via 6816ffa May 16, 2024 12:32
@v-atulyadav v-atulyadav merged commit c699e75 into Azure:master May 16, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants