Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/#412 incorrect role definition & change evaluationDelay to AfterProvisioning #413

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Fix/#412 incorrect role definition & change evaluationDelay to AfterProvisioning #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14507f1
Change roleDefinitionIds to owner
aschabus Dec 18, 2023
7e8e025
Change "evaluationDelay" to "AfterProvisioning"
aschabus Dec 19, 2023
38f0a2c
Change default TagValue from dv to dev
aschabus Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions policyDefinitions/General/deploy-resource-lock-on-rgs-tag-exclusion/azurepolicy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"type": "Microsoft.Authorization/policyDefinitions",
"properties": {
"displayName": "Deploy Resource Lock on RGs - tag exclusion",
"description": "Automatically deploys a resource lock to resources that are not in the dv environment to prevent accidental deletion.",
"description": "Automatically deploys a resource lock to resources that are not in the dev environment to prevent accidental deletion.",
"metadata": {
"version": "1.0.0",
"version": "1.0.1",
"category": "General"
},
"mode": "All",
Expand All @@ -24,7 +24,7 @@
"displayName": "Value of the tag for exclusion",
"description": "If you decided to configure an exclusion, you need to configure a specific value of the tag you defined. Put the tag value for exclusion in this field"
},
"defaultValue": "dv"
"defaultValue": "dev"
},
"effect": {
"type": "String",
Expand Down Expand Up @@ -59,6 +59,7 @@
"effect": "[parameters('effect')]",
"details": {
"type": "Microsoft.Authorization/locks",
"evaluationDelay": "AfterProvisioning",
"existenceCondition": {
"field": "Microsoft.Authorization/locks/level",
"equals": "CanNotDelete"
Expand All @@ -84,7 +85,7 @@
}
},
"roleDefinitionIds": [
"/providers/Microsoft.Authorization/roleDefinitions/35b50af1-b556-492f-8595-cbf5cb531055"
"/providers/Microsoft.Authorization/roleDefinitions/8e3af657-a8ff-443c-a75c-2fe8c4bcb635"
]
}
}
Expand Down
3 changes: 2 additions & 1 deletion policyDefinitions/General/deploy-resource-lock-on-rgs-tag-exclusion/azurepolicy.rules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"effect": "[parameters('effect')]",
"details": {
"type": "Microsoft.Authorization/locks",
"evaluationDelay": "AfterProvisioning",
"existenceCondition": {
"field": "Microsoft.Authorization/locks/level",
"equals": "CanNotDelete"
Expand All @@ -42,7 +43,7 @@
}
},
"roleDefinitionIds": [
"/providers/Microsoft.Authorization/roleDefinitions/35b50af1-b556-492f-8595-cbf5cb531055"
"/providers/Microsoft.Authorization/roleDefinitions/8e3af657-a8ff-443c-a75c-2fe8c4bcb635"
]
}
}
Expand Down