Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .yml extension for the config file #162

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

SvenAelterman
Copy link
Contributor

@SvenAelterman SvenAelterman commented Jul 21, 2024

Overview/Summary

The intent seems to be that both .yaml and .yml would be valid configuration file extensions. However, in the current code, a .yml file extension would attempted to be parsed as JSON.

This PR fixes/adds/changes/removes

  1. bug: .yml file extension for config file is not processed correctly. ALZ-PowerShell-Module#153

Breaking Changes

N/A

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate
Copy link
Member

@SvenAelterman Apologies for the slow response here. Will merge this now.

Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredfholgate jaredfholgate merged commit 4ad4c79 into Azure:main Sep 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants