Add AMG private endpoint commands #7879
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| grafana mpe | sub group grafana mpe added |
||
| grafana private-endpoint-connection | sub group grafana private-endpoint-connection added |
microsoft-github-policy-service
bot
requested review from
yonzhan,
wangzelin007,
kairu-ms and
jsntcy
microsoft-github-policy-service
bot
added
customer-reported
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
| self.check('connectionState.status', 'Pending') | ||
| ]) | ||
|
|
||
| self.cmd('grafana managed-private-endpoint refresh -g {rg} --workspace-name {name}') |
There was a problem hiding this comment.
any possible checks we can do for the 'refresh' command?
There was a problem hiding this comment.
Not directly on the call to the refresh command. The refresh command does not output anything. We check that the connection state updates from the refresh though by checking before and after.
| self.check('length([])', 0) | ||
| ]) | ||
|
|
||
| self.cmd('network vnet create -g {rg} -n {vnet_name} -l {location} --subnet-name {subnet_name}') |
There was a problem hiding this comment.
any possible checks we can do after creation to check that the resource attributes are what we expect?
There was a problem hiding this comment.
Added checks to the mpe creation, the other create calls are creating non-amg resources.
|
@yonzhan ready for review |
|
[Release] Update index.json for extension [ amg ] : https://dev.azure.com/azclitools/release/_build/results?buildId=186990&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az grafana
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)Adds private endpoint commands to azure managed grafana extension. Generated via aaz-dev-tools