Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] az aks create/update: Support UserAssigned Managed Identity for grafana linking in managed prometheus #7886

Merged

Conversation

bragi92
Copy link
Member

@bragi92 bragi92 commented Aug 14, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

az aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azure-monitor-metrics --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}"

az aks create -n kaveeshcli22 -g kaveeshcli --disable-azure-monitor-metrics

Description
Azure Managed Grafana now has support for UserAssigned Managed Identity and we're adding support for it in the managed prometheus addon.

Testing Guide

  • Set context to one of the air gapped clouds
  • Use the command with the grafana-resource-id parameter similar to az aks create -n kaveeshcli22 -g kaveeshcli --location {cluster_location} --enable-azure-monitor-metrics --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}" and it should result in a a successful result. Please use a grafana resource that is creating/updated using a user assigned managed identity

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Hi @bragi92,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

azure-client-tools-bot-prd bot commented Aug 14, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 14, 2024

AKS

Copy link

github-actions bot commented Aug 14, 2024

@bragi92 bragi92 changed the title [AKS] az aks create/update: Support in place param updates for managed prom [AKS] az aks create/update: Support UserAssigned Managed Identity for grafana linking in managed prometheus Aug 14, 2024
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Queued live test to validate the change, test passed!

  • test_aks_create_with_azuremonitormetrics
  • test_aks_update_with_azuremonitormetrics
  • test_aks_create_with_azuremonitorappmonitoring
  • test_aks_update_with_azuremonitorappmonitoring

@yanzhudd yanzhudd merged commit 820478f into Azure:main Aug 23, 2024
20 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=183645&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot extension/grafana az grafana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants