-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] az aks create/update
: Support UserAssigned Managed Identity for grafana linking in managed prometheus
#7886
[AKS] az aks create/update
: Support UserAssigned Managed Identity for grafana linking in managed prometheus
#7886
Conversation
Hi @bragi92, |
️✔️Azure CLI Extensions Breaking Change Test
|
AKS |
|
az aks create/update
: Support in place param updates for managed promaz aks create/update
: Support UserAssigned Managed Identity for grafana linking in managed prometheus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Queued live test to validate the change, test passed!
- test_aks_create_with_azuremonitormetrics
- test_aks_update_with_azuremonitormetrics
- test_aks_create_with_azuremonitorappmonitoring
- test_aks_update_with_azuremonitorappmonitoring
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=183645&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
az aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azure-monitor-metrics --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}"
az aks create -n kaveeshcli22 -g kaveeshcli --disable-azure-monitor-metrics
Description
Azure Managed Grafana now has support for UserAssigned Managed Identity and we're adding support for it in the managed prometheus addon.
Testing Guide
az aks create -n kaveeshcli22 -g kaveeshcli --location {cluster_location} --enable-azure-monitor-metrics --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}"
and it should result in a a successful result. Please use a grafana resource that is creating/updated using a user assigned managed identityGeneral Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.