Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VM Repair tests failing for no good reason #7890

Merged
merged 16 commits into from
Aug 29, 2024

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented Aug 19, 2024

at least 11 of the vm repair tests are failing for non-code reasons. An Image version no longer exists, or the test does not have access to a resource it made, other maintenance that needs to be done.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Aug 19, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Sandido,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 19, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Aug 20, 2024

@Sandido Sandido marked this pull request as ready for review August 23, 2024 21:14
@zhoxing-ms zhoxing-ms merged commit 087db12 into Azure:main Aug 29, 2024
19 of 20 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/release/_build/results?buildId=185158&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants