-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{virtual-wan} Remove ADAL dependencies #7934
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Hi @cxznmhdcxz, |
virtual-wan |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
@@ -176,7 +176,7 @@ def test_azure_vpn_server_config_basic_scenario(self, resource_group): | |||
]) | |||
|
|||
self.cmd('network vpn-server-config delete -n {vserverconfig} -g {rg} -y') | |||
with self.assertRaisesRegexp(SystemExit, '3'): | |||
with self.assertRaisesRegex(SystemExit, '3'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain why we replace assertRaisesRegexp
with assertRaisesRegex
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's error of assertRaisesRegexp
self.cmd('network vpn-server-config delete -n {vserverconfig} -g {rg} -y')
> with self.assertRaisesRegexp(SystemExit, '3'):
E AttributeError: 'AzureVWanVHubScenario' object has no attribute 'assertRaisesRegexp'. Did you mean: 'assertRaisesRegex'?
azure-cli-extensions\src\virtual-wan\azext_vwan\tests\latest\test_azure_vwan_vhub_commands.py:179: AttributeError
It's deprecated and renamed to assertRaisesRegex()
for python3
https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRaisesRegex
1c1431b
to
7204ee5
Compare
[Release] Update index.json for extension [ virtual-wan ] : https://dev.azure.com/azclitools/release/_build/results?buildId=186379&view=results |
Remove ADAL dependencies,
replace functions/models in msrestazure library with parity functions in azure.mgmt.core library or azure.core library
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.