Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-cli-extension: Release for MicrosoftCache.RedisEnterprise - 2024-09-01 PREVIEW #8013

Conversation

priyankarking
Copy link
Contributor

@priyankarking priyankarking commented Sep 23, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Sep 23, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️redisenterprise
rule cmd_name rule_message suggest_message
⚠️ 1010 - ParaPropUpdate redisenterprise create cmd redisenterprise create update parameter sku: updated property choices from ['EnterpriseFlash_F1500', 'EnterpriseFlash_F300', 'EnterpriseFlash_F700', 'Enterprise_E1', 'Enterprise_E10', 'Enterprise_E100', 'Enterprise_E20', 'Enterprise_E200', 'Enterprise_E400', 'Enterprise_E5', 'Enterprise_E50'] to ['Balanced_B0', 'Balanced_B1', 'Balanced_B10', 'Balanced_B100', 'Balanced_B1000', 'Balanced_B150', 'Balanced_B20', 'Balanced_B250', 'Balanced_B3', 'Balanced_B350', 'Balanced_B5', 'Balanced_B50', 'Balanced_B500', 'Balanced_B700', 'ComputeOptimized_X10', 'ComputeOptimized_X100', 'ComputeOptimized_X150', 'ComputeOptimized_X20', 'ComputeOptimized_X250', 'ComputeOptimized_X3', 'ComputeOptimized_X350', 'ComputeOptimized_X5', 'ComputeOptimized_X50', 'ComputeOptimized_X500', 'ComputeOptimized_X700', 'EnterpriseFlash_F1500', 'EnterpriseFlash_F300', 'EnterpriseFlash_F700', 'Enterprise_E1', 'Enterprise_E10', 'Enterprise_E100', 'Enterprise_E20', 'Enterprise_E200', 'Enterprise_E400', 'Enterprise_E5', 'Enterprise_E50', 'FlashOptimized_A1000', 'FlashOptimized_A1500', 'FlashOptimized_A2000', 'FlashOptimized_A250', 'FlashOptimized_A4500', 'FlashOptimized_A500', 'FlashOptimized_A700', 'MemoryOptimized_M10', 'MemoryOptimized_M100', 'MemoryOptimized_M1000', 'MemoryOptimized_M150', 'MemoryOptimized_M1500', 'MemoryOptimized_M20', 'MemoryOptimized_M2000', 'MemoryOptimized_M250', 'MemoryOptimized_M350', 'MemoryOptimized_M50', 'MemoryOptimized_M500', 'MemoryOptimized_M700']
⚠️ 1011 - SubgroupAdd redisenterprise database access-policy-assignment sub group redisenterprise database access-policy-assignment added
⚠️ 1006 - ParaAdd redisenterprise database create cmd redisenterprise database create added parameter access_keys_authentication
⚠️ 1006 - ParaAdd redisenterprise database create cmd redisenterprise database create added parameter defer_upgrade
⚠️ 1006 - ParaAdd redisenterprise database list cmd redisenterprise database list added parameter pagination_limit
⚠️ 1006 - ParaAdd redisenterprise database list cmd redisenterprise database list added parameter pagination_token
⚠️ 1006 - ParaAdd redisenterprise database update cmd redisenterprise database update added parameter access_keys_authentication
⚠️ 1006 - ParaAdd redisenterprise database update cmd redisenterprise database update added parameter defer_upgrade
⚠️ 1006 - ParaAdd redisenterprise update cmd redisenterprise update added parameter high_availability
⚠️ 1010 - ParaPropUpdate redisenterprise update cmd redisenterprise update update parameter sku: updated property choices from ['EnterpriseFlash_F1500', 'EnterpriseFlash_F300', 'EnterpriseFlash_F700', 'Enterprise_E1', 'Enterprise_E10', 'Enterprise_E100', 'Enterprise_E20', 'Enterprise_E200', 'Enterprise_E400', 'Enterprise_E5', 'Enterprise_E50'] to ['Balanced_B0', 'Balanced_B1', 'Balanced_B10', 'Balanced_B100', 'Balanced_B1000', 'Balanced_B150', 'Balanced_B20', 'Balanced_B250', 'Balanced_B3', 'Balanced_B350', 'Balanced_B5', 'Balanced_B50', 'Balanced_B500', 'Balanced_B700', 'ComputeOptimized_X10', 'ComputeOptimized_X100', 'ComputeOptimized_X150', 'ComputeOptimized_X20', 'ComputeOptimized_X250', 'ComputeOptimized_X3', 'ComputeOptimized_X350', 'ComputeOptimized_X5', 'ComputeOptimized_X50', 'ComputeOptimized_X500', 'ComputeOptimized_X700', 'EnterpriseFlash_F1500', 'EnterpriseFlash_F300', 'EnterpriseFlash_F700', 'Enterprise_E1', 'Enterprise_E10', 'Enterprise_E100', 'Enterprise_E20', 'Enterprise_E200', 'Enterprise_E400', 'Enterprise_E5', 'Enterprise_E50', 'FlashOptimized_A1000', 'FlashOptimized_A1500', 'FlashOptimized_A2000', 'FlashOptimized_A250', 'FlashOptimized_A4500', 'FlashOptimized_A500', 'FlashOptimized_A700', 'MemoryOptimized_M10', 'MemoryOptimized_M100', 'MemoryOptimized_M1000', 'MemoryOptimized_M150', 'MemoryOptimized_M1500', 'MemoryOptimized_M20', 'MemoryOptimized_M2000', 'MemoryOptimized_M250', 'MemoryOptimized_M350', 'MemoryOptimized_M50', 'MemoryOptimized_M500', 'MemoryOptimized_M700']

Copy link

Hi @priyankarking,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 23, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Sep 23, 2024

@evelyn-ys
Copy link
Member

Please fix CI failures

@priyankarking
Copy link
Contributor Author

priyankarking commented Sep 23, 2024

"azdev style redisenterprise is failing for files/area which I have not changed. @evelyn-ys can you pls help here why it is failing ?

@evelyn-ys
Copy link
Member

"azdev style redisenterprise is failing for files/area which I have not changed. @evelyn-ys can you pls help here why it is failing ?

No matter why, just fix it. It's not difficult linter rules, right?

@priyankarking
Copy link
Contributor Author

"azdev style redisenterprise is failing for files/area which I have not changed. @evelyn-ys can you pls help here why it is failing ?

No matter why, just fix it. It's not difficult linter rules, right?

Its coming on autogenerate code, I am not able to fix it. And this checks seems not mandatory for merge.

@evelyn-ys evelyn-ys merged commit 1bf12ca into Azure:main Sep 25, 2024
19 of 20 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ redisenterprise ] : https://dev.azure.com/azclitools/release/_build/results?buildId=192645&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants