Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkCloud Azure-cli-extension 2024-07-01 API #8025

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

priyamshet
Copy link
Member

@priyamshet priyamshet commented Sep 25, 2024


NetworkCloud Azure-cli-extension update for API version 2024-07-01 API

Corresponding AAZ PR :Azure/aaz#574
This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Sep 25, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @priyamshet,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 25, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Sep 25, 2024

Hi @priyamshet

⚠️ Release Requirements

Module: networkcloud

  • ⚠️ Remove azext.isPreview: true in azext_metadata.json for networkcloud

Notes

@priyamshet priyamshet force-pushed the priyashet/networkcloud_20240701 branch from cf66810 to 7c5527f Compare September 25, 2024 16:35
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 25, 2024
@mbashtovaya
Copy link
Member

mbashtovaya commented Sep 25, 2024

Hi @priyamshet

⚠️ Release Requirements

Module: networkcloud

  • ⚠️ Remove azext.isPreview: true in azext_metadata.json for networkcloud

Notes

according to the mentioned document. 2.0.0b4 is the next preview version and should be marked with the isPreview=true. We need clarification as to why this is being flagged.

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 26, 2024
@mbashtovaya
Copy link
Member

mbashtovaya commented Oct 2, 2024

@necusjz or @yonzhan can you help with merging?

@mbashtovaya mbashtovaya removed the request for review from necusjz October 2, 2024 18:49
@yonzhan yonzhan requested review from necusjz and jsntcy October 2, 2024 22:13
@kairu-ms kairu-ms merged commit e6578a8 into Azure:main Oct 3, 2024
25 of 28 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Oct 3, 2024

[Release] Update index.json for extension [ networkcloud ] : https://dev.azure.com/azclitools/release/_build/results?buildId=194448&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants